Closed Bug 1616775 Opened 3 years ago Closed 3 years ago

Support running ContentBlocking::AllowAccessFor in both parent and child

Categories

(Core :: Privacy: Anti-Tracking, task, P1)

task

Tracking

()

RESOLVED FIXED
mozilla77
Fission Milestone M6a
Tracking Status
firefox77 --- fixed

People

(Reporter: dimi, Assigned: dimi)

References

Details

Attachments

(7 files, 2 obsolete files)

47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review

We are going to implement two versions of AddFirstPartyStorageAccessGrantedFor:

  • When the parent window and tracker’s window are in the same process, we use the current implementation(check permission in the child) to guarantee permission will be updated synchronously.
  • When the parent window and tracker’s window are NOT in the same process, we use the same API but implement the logic in the parent.

See design document for more details.

Depends on: 1612349
Depends on: 1612350
Depends on: 1616570

Tracking for Fission Nightly (M6)

Fission Milestone: --- → M6
Depends on: 1620602
Summary: Support running AddFirstPartyStorageAccessGrantedFor in both parent and child → Support running ContentBlocking::AllowAccessFor in both parent and child
Depends on: 1623268
Depends on: 1624552
Depends on: 1624607

Tentatively moving P1 Fission M6 bugs to M6a.

Fission Milestone: M6 → M6a
Depends on: 1628003
Depends on: 1628063
Attachment #9140707 - Attachment description: Bug 1616775 - P1. WindowContext r=timhuang → Bug 1616775 - P1. Add IsThirdPartyWindow and IsThirdPartyTrackingResourceWindow fields to WindowContext. r=timhuang
Attachment #9140708 - Attachment description: Bug 1616775 - P2. GetPrincipalAndTrackingOrigin r=timhuang → Bug 1616775 - P2. Support getting principal and tracking origin by BrowsingContext. r=timhuang
Attachment #9140709 - Attachment description: Bug 1616775 - P3. Add AllowAccessForContinue r=timhuang → Bug 1616775 - P3. Add AllowAccessForContinue to support running in the parent. r=timhuang
Attachment #9140711 - Attachment description: Bug 1616775 - P5. Support getting tracking origin in the parent r=timhuang → Bug 1616775 - P5. Get tracking origin in AllowAccesForContinue when it is not available in the child processes. r=timhuang
Attachment #9140712 - Attachment description: Bug 1616775 - P6. Add AllowAccessForGranted r=timhuang → Bug 1616775 - P6. Add AllowAccessForGranted to process that tasks need the parent window. r=timhuang

Depends on D71101

Attachment #9140709 - Attachment description: Bug 1616775 - P3. Add AllowAccessForContinue to support running in the parent. r=timhuang → Bug 1616775 - P3. Add CompleteAllowAccessFor to support running in the parent. r=timhuang
Attachment #9140710 - Attachment description: Bug 1616775 - P4. Add AllowAccessForContinue IPDL r=timhuang → Bug 1616775 - P4. Add CompleteAllowAccessFor IPDL r=timhuang
Attachment #9140711 - Attachment description: Bug 1616775 - P5. Get tracking origin in AllowAccesForContinue when it is not available in the child processes. r=timhuang → Bug 1616775 - P5. Get tracking origin in CompleteAllowAccesFor when it is not available in the child processes. r=timhuang
Attachment #9140712 - Attachment description: Bug 1616775 - P6. Add AllowAccessForGranted to process that tasks need the parent window. r=timhuang → Bug 1616775 - P6. Add OnAllowAccessFor to process tasks that need a parent window. r=timhuang
Attachment #9140872 - Attachment is obsolete: true
Attachment #9140871 - Attachment is obsolete: true
Pushed by dlee@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ae01b3db6250
P1. Add IsThirdPartyWindow and IsThirdPartyTrackingResourceWindow fields to WindowContext. r=timhuang,baku,farre
https://hg.mozilla.org/integration/autoland/rev/414a605d677a
P2. Support getting principal and tracking origin by BrowsingContext. r=timhuang,baku
https://hg.mozilla.org/integration/autoland/rev/123b6c3a0ede
P3. Add CompleteAllowAccessFor to support running in the parent. r=timhuang,baku
https://hg.mozilla.org/integration/autoland/rev/3b1dbe909aaf
P4. Add CompleteAllowAccessFor IPDL r=timhuang,baku
https://hg.mozilla.org/integration/autoland/rev/577f090dae54
P5. Get tracking origin in CompleteAllowAccesFor when it is not available in the child processes.  r=timhuang,baku
https://hg.mozilla.org/integration/autoland/rev/9be5ae499d84
P6. Add OnAllowAccessFor to process tasks that need a parent window. r=timhuang,baku
https://hg.mozilla.org/integration/autoland/rev/312b4abacc2d
P7. Add IPC for ContentBlockingNotifier::OnDecision r=timhuang,baku
Regressions: 1632815
Regressions: 1634414
Regressions: 1635020
Regressions: 1644266
You need to log in before you can comment on or make changes to this bug.