1623383 - Cleanup URIFixup.jsm

Status: RESOLVED FIXED

(Core :: DOM: Navigation, task, P3)

Description

[Marco Bonardo [:mak]]

The initial implementation of URIFixup.jsm from bug 1496578 is in large chunks a direct port of the cpp code, it contains some string loops and inefficiencies that were not modified to avoid introducing too many risks of regressions at once.

Once that lands, we can move on with cleaning up the code to use proper js.

A few things that come to my mind:

1. strings walking, most of it can be replaced with regex or other string functions
2. one of the loops uses a custom NOT_FOUND value because the cpp code was overflowing kNotFound (-1) into an unsigned integer and all the code was based on that

Comment 1

[Marco Bonardo [:mak]]

Another thing to cleanup would be to check if the following else can be merged into the previous if (... || !possiblyHostPortRegex.test(uriString))

else {
        // If the given URL has a user:password we can't just pass it to the
        // external protocol handler; we'll try using it with http instead
        // later
        info.fixedURI = null;
      }

Comment 2

[Marco Bonardo [:mak]]

Attachment: Bug 1623383 - Cleanup URIFixup.jsm. r=harry

Comment 3

[Marco Bonardo [:mak]]

Attachment: Bug 1623383 - Merge some conditions in URIFixup.jsm. r=harry

Depends on D73687

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cad2659a1a16
Cleanup URIFixup.jsm. r=harry
https://hg.mozilla.org/integration/autoland/rev/ffa35c5164f9
Merge some conditions in URIFixup.jsm. r=harry

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/cad2659a1a16
https://hg.mozilla.org/mozilla-central/rev/ffa35c5164f9