1623433 - Make it easier to add new linters

Status: NEW

(Developer Infrastructure :: Lint and Formatting, task)

Description

[Andrew Halberstadt [:ahal]]

I noticed that many of our lint implementations are using very similar patterns. This is an opportunity to consolidate some of the code into a shared place (e.g mozlint.util). This would make it slightly easier to add new linters in the future and make maintenance easier. We should also re-organize the tools/lint directory. It is kind of a mess.

Comment 1

[Andrew Halberstadt [:ahal]]

I have some patches lying around I want to get landed, so I'll take it for now. But there will be a lot more we can do in this area so will leave the bug open.

Comment 2

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1623433 - [mozlint] Create a LintProcess utility class to consolidate some of our lint implementations, r?#linter-reviewers

Comment 3

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1623433 - [mozlint] LineType linters should not try to open non-existent paths, r?#linter-reviewers!

This can happen when using --workdir or --outgoing if a modified file was
(re)moved.

Depends on D67410

Comment 4

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1623433 - [lint] Move all linter implementations under 'tools/lint/impl', r?#linter-reviewers!,Standard8!

Depends on D67411

Comment 5

[Phabricator Automation]

Comment on attachment 9134284 [details]
Bug 1623433 - [mozlint] LineType linters should not try to open non-existent paths, r?#linter-reviewers!

Revision D67411 was moved to bug 1570654. Setting attachment 9134284 [details] to obsolete.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/305317042898
[mozlint] Create a LintProcess utility class to consolidate some of our lint implementations, r=linter-reviewers,sylvestre

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/305317042898

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:ahal, maybe it's time to close this bug?

Comment 9

[Andrew Halberstadt [:ahal]]

There's still work to be done here.