1623529 - Can't do Java profiling any more, checkbox doesn't stick

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect, P1)

Description

[Markus Stange [:mstange]]

Steps to reproduce:

1. Go to about:debugging and connect to Fenix on Android.
2. Click the Profile performance button.
3. Choose Settings -> Custom, and go to Edit Settings...
4. Check the "Java" feature checkbox.
5. Click Save settings and go back.

Expected results:
The Java feature should now be enabled.

Actual results:
The summary does not list the Java feature. Going back to edit setting shows the Java feature still unchecked.

The "host" Gecko doesn't support Java profiling. Are we ever asking the host for its supported profiler features? We shouldn't do that for remote profiling features.

Comment 1

[Greg Tatum [:gregtatum]]

Attachment: Bug 1623529 - Clean up PerfFront.getSupportedFeatures backwards FF 72 compatibility; r?julienw

The current Firefox release channel is 74, which means this old mitigation is no
longer needed. getSupportedFeatures is supported on all targets.

Comment 2

[Greg Tatum [:gregtatum]]

Attachment: Bug 1623529 - Add "java" to the profiler presets by default; r?julienw

The feature should only be enabled if it's supported, e.g on
mobile phones.

Depends on D67526

Comment 3

[Greg Tatum [:gregtatum]]

Attachment: Bug 1623529 - Fix supported features used in the profiler; r?julienw

about:profiling was failing to use the supported features of the target
and was instead only checking the locally supported features.

Depends on D67527

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/054d227f6c63
Clean up PerfFront.getSupportedFeatures backwards FF 72 compatibility; r=julienw
https://hg.mozilla.org/integration/autoland/rev/5eacb3c30029
Add "java" to the profiler presets by default; r=julienw
https://hg.mozilla.org/integration/autoland/rev/d44263e0b47b
Fix supported features used in the profiler; r=julienw

Comment 5

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/054d227f6c63
https://hg.mozilla.org/mozilla-central/rev/5eacb3c30029
https://hg.mozilla.org/mozilla-central/rev/d44263e0b47b

Comment 6

[Ryan VanderMeulen [:RyanVM]]

What bug caused this regression?

Comment 7

[Greg Tatum [:gregtatum]]

I think it was Bug 1597381