1623562 - Refactor uses of nsIDocShell.allowPlugins

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task)

Description

[u480271]

As requested in review comments for Bug 1621192, follow up patch removing access to nsDocShell.allowPlugins.

Comment 1

[u480271]

Attachment: Bug 1623562 - Refactor allowPlugins to use BrowsingContext. r?nika

Comment 2

[u480271]

Attachment: Bug 1623562 - P1: Move JS binding of allowPlugins to BrowsingContext. r?nika

Depends on D67428

Comment 3

[Kershaw Chang [:kershaw]]

Not sure why this is a networking bug.
Anyway, I think the priority should not be P4.

Comment 4

[u480271]

Discussed with :Nika and it was decided to abandon the refactoring to move access to allowPlugins from js.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The component has been changed since the backlog priority was decided, so we're resetting it.
For more information, please visit auto_nag documentation.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/20f1bb2d5bd2
Refactor allowPlugins to use BrowsingContext. r=nika

Comment 7

[Narcis Beleuzu [:NarcisB]]

Backed out for bc failures on browser_bug1335475.js and browser_flashblock_on_with_always_activate.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/f9dd7d99bb3fc167b8adaeddf957e1e8784580c8
Log browser_bug1335475.js : https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=293989249&repo=autoland&lineNumber=15268
Log browser_flashblock_on_with_always_activate.js: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=293989233&repo=autoland&lineNumber=55836

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ace103380c5c
Refactor allowPlugins to use BrowsingContext. r=nika

Comment 9

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/ace103380c5c