Closed Bug 1623563 Opened 4 years ago Closed 4 years ago

allowPlugins moved from nsIDocShell to BrowsingContext.

Categories

(Thunderbird :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: u480271, Unassigned)

Details

Attachments

(1 file)

Bug 1623562 breaks docshell.allowPlugins = false at https://searchfox.org/comm-central/source/chat/content/browserRequest.js#142 and https://searchfox.org/comm-central/source/suite/components/helpviewer/content/help.js#122.

These should become:

browser.docShell.browsingContext.allowPlugins = false;
Component: Untriaged → Add-Ons: Extensions API
Component: Add-Ons: Extensions API → General
Assignee: nobody → mkmelin+mozilla
Status: NEW → ASSIGNED
Attachment #9134368 - Flags: review?(khushil324)
Comment on attachment 9134368 [details] [diff] [review]
bug1623563_allowplugins_browsercontext.patch

Review of attachment 9134368 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.
Attachment #9134368 - Flags: review?(khushil324) → review+

Looks like I jumped the gun. In review for Bug 1623562, it was decided not to move allowPlugins from nsIDocShell so these changes won't be needed.

No longer regressed by: 1623562
Assignee: mkmelin+mozilla → nobody
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: