Closed
Bug 1623563
Opened 4 years ago
Closed 4 years ago
allowPlugins moved from nsIDocShell to BrowsingContext.
Categories
(Thunderbird :: General, defect)
Thunderbird
General
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: u480271, Unassigned)
Details
Attachments
(1 file)
2.30 KB,
patch
|
khushil324
:
review+
|
Details | Diff | Splinter Review |
Bug 1623562 breaks docshell.allowPlugins = false
at https://searchfox.org/comm-central/source/chat/content/browserRequest.js#142 and https://searchfox.org/comm-central/source/suite/components/helpviewer/content/help.js#122.
These should become:
browser.docShell.browsingContext.allowPlugins = false;
Updated•4 years ago
|
Component: Untriaged → Add-Ons: Extensions API
Updated•4 years ago
|
Component: Add-Ons: Extensions API → General
Comment 1•4 years ago
|
||
Assignee: nobody → mkmelin+mozilla
Status: NEW → ASSIGNED
Attachment #9134368 -
Flags: review?(khushil324)
Comment 2•4 years ago
|
||
Comment on attachment 9134368 [details] [diff] [review] bug1623563_allowplugins_browsercontext.patch Review of attachment 9134368 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me.
Attachment #9134368 -
Flags: review?(khushil324) → review+
Looks like I jumped the gun. In review for Bug 1623562, it was decided not to move allowPlugins
from nsIDocShell
so these changes won't be needed.
Updated•4 years ago
|
Assignee: mkmelin+mozilla → nobody
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•