1623631 - Don't bundle mimeapps.list in snap

Status: RESOLVED FIXED

(Release Engineering Graveyard :: Release Automation: Snap, enhancement)

Description

[Ken VanDine]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:75.0) Gecko/20100101 Firefox/75.0

Steps to reproduce:

The current snap bundles a mimeapps.list and built mime.cache to use xdg-open from the core snap. Now that portals are more widely available, we should drop this to take advantage of the portal infrastructure.

Comment 1

[Ken VanDine]

Attachment: Bug 1623631 - Drop bundled mimeapps.list, mime cache and set TMPDIR to better take advantage of portals r=rail

Comment 2

[Ken VanDine]

Attachment: Bug 1623631 - Set GTK_USE_PORTAL to enable xdg-desktop-portal support r=jlorenzo

Comment 3

[Krish De Souza]

Hi Johan,

Sorry I was just looking at this to try and follow what changes have occurred since the last time i looked at snapcraft. I was a bit surprised at how small the new firefox beta snap is compared to stable.

I wanted to post some comments, but phabricator didn't seem to enable me to do so.

In firefox.snapcraft.yaml.in, isn't lines 67-78 (in the new patch) unnecessary as it's removing files from the old gnome-3-28 snap which isn't being used anymore?

Also I think line 82 needs to be updated to 'after: [firefox]'.

Kind regards,
Krish

Comment 4

[Johan Lorenzo [:jlorenzo] - On PTO - Back on July 28th]

Hey Krish!

You're totally right! These lines aren't needed at all. They were added by hg when I rebased my patch and I hadn't realized it before landing the changes. This bug will remove these lines.

Thanks again for your help! 😃

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/015f42782c5e
Drop bundled mimeapps.list, mime cache and set TMPDIR to better take advantage of portals r=rail

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2f931487a68b
Set GTK_USE_PORTAL to enable xdg-desktop-portal support r=jlorenzo

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/015f42782c5e
https://hg.mozilla.org/mozilla-central/rev/2f931487a68b

Comment 8

[Johan Lorenzo [:jlorenzo] - On PTO - Back on July 28th]

Comment on attachment 9134410 [details]
Bug 1623631 - Drop bundled mimeapps.list, mime cache and set TMPDIR to better take advantage of portals r=rail

Beta/Release Uplift Approval Request

• User impact if declined: Canonical would like to qualify Firefox Snap as part of their Ubuntu 20.10 cycle. Waiting for 78 to reach beta would put them past the 3rd of their cycle. Having this patch is a requirement to test the "deb to snap" migration on their end.

For the record, it would be easier for us to hand them out a nightly if bug 1451694 was addressed. That bug has never been high enough on the agenda.

• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Medium
• Why is the change risky/not risky? (and alternatives if risky): This was tested as part of our infra at https://treeherder.mozilla.org/#/jobs?repo=try&revision=984a1e1b1abdae69d34afb5d7588fa368889357e. Ken from Canonical is a maintainer on Snap and knows our Snap inside out.
• String changes made/needed: None

Comment 9

[Pascal Chevrel:pascalc]

Comment on attachment 9134410 [details]
Bug 1623631 - Drop bundled mimeapps.list, mime cache and set TMPDIR to better take advantage of portals r=rail

Approved for beta, thanks.

Comment 10

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e0eb639a7e1f
https://hg.mozilla.org/releases/mozilla-beta/rev/c8911bdfe037

Comment 11

[Hugo Osvaldo Barrera]

I'm trying to make Firefox use the document portal (though not using snaps), but can't quite figure out what needs to be done.

It seems that just using GTK_USE_PORTAL and widget.use-xdg-desktop-portal is not enough; the file chooser portal is used, but it returns the path to the file on the host, and not a path provided via the document portal, so opening the file fails.

Any hints on what might be missing? (see also https://bugzilla.mozilla.org/show_bug.cgi?id=1743145).