1623651 - Update CDM headers to ones supporting AV1

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, task, P3)

Description

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

We need to update the CDM headers used by Widevine in order to support encrypted av1 as the new headers contain enums we need.

This involves pulling the files from the Chromium repo. The following 4 files should be updated:

• content_decryption_module.h
• decryption_module_export.h
• content_decryption_module_ext.h
• content_decryption_module_proxy.h

Note: doing so will remove support for CDM interface 9. Bug 1623661 tracks removing our usage of that interface so we can update the headers.

See bug 1487811 for the last time the headers were bumped.

Comment 1

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Attachment: Bug 1623651 - Pull new CDM headers from Chromium. r?alwu,dminor

Headers are pulled from Chromium revision
bc262e26cd2dca812f05bdad3b37398839e63007.

Comment 2

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Attachment: Bug 1623651 - Update enums that have changed with CDM header bump. r?alwu,dminor

The CDM header bump has moved some enums, as well as using enum classes instead
of old style enums. This patch updates consumers of these enums to be compatible
with the new headers.

Drive by remove using namespace cdm from a couple of files as

• In some places I'd already been using fully qualified names.
• I prefer the fully qualified names as they make it clear when enums are coming
  from the cdm namespace and cdm:: is not a particularly more verbose thing to
  have on identifiers.

Comment 3

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

The first patch here is a straight import of source from Chromium. We've historically preferred this approach as it makes it easier to diff (we don't format per bug 1486502). This will undo the changes from bug 1613985. :sg, is this a concern?

Comment 4

[Simon Giesecke [:sg] [he/him]]

No, that's fine. I probably wasn't aware that these were external files. I am not completely sure since I did some manual work after applying the clang-tidy changes, but I assume that these were suggested by clang-tidy. In that case, they should be excluded from clang-tidy analysis. Sylvestre, WDYT?

Comment 5

[Sylvestre Ledru [:Sylvestre]]

They should be ignored if listed in https://searchfox.org/mozilla-central/source/tools/rewriting/ThirdPartyPaths.txt
what is the path which has been reformatted?

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fa57f4290efb
Pull new CDM headers from Chromium. r=alwu,dminor
https://hg.mozilla.org/integration/autoland/rev/e186dc84781f
Update enums that have changed with CDM header bump. r=alwu,dminor

Comment 7

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

I'm going to land the existing changes. Please NI me if there's anything more needed to stop these being tidied and I will create a follow up bug.

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/fa57f4290efb
https://hg.mozilla.org/mozilla-central/rev/e186dc84781f