1623666 - Always show activity stream top sites in the address bar dropdown

Status: RESOLVED FIXED

(Firefox :: Address Bar, enhancement, P2)

Description

[Verdi [:verdi] Best to slack me]

We decided to always show top sites in the address bar dropdown regardless of whether top sites are shown on the new tab page. The problem is that if top sites are not show on the new tab page we don't have access to that list and instead we show the old history list. If possible we should find a way to access the activity stream top site list for display in the address bar even when they are not shown on the new tab page. This way the sites shown with the feature always come from the same data source and enables users to have control over them.

Comment 1

[Asif Youssuff]

There is some pretty negative feedback to this idea here: https://www.reddit.com/r/firefox/comments/fw485c/oh_wow_the_new_url_bar_is_absolutely_atrocious_in/fmms9sp/

I have this disabled in two different ways, both of which were ignored to display this in the URL bar.

Wouldn't it be much more sane, to make Home -> Topsites being unchecked affect BOTH places? If I say I don't want top sites, I don't want top sites, not to give them to me in a second location that I have to jump through hoops to turn off.

If someone takes the time to turn them OFF, turn them off in both places, don't affect one location and ignore another.

Comment 2

[Tony Green]

(In reply to Verdi [:verdi] Best to slack me from comment #0)

We decided to always show top sites in the address bar dropdown regardless of whether top sites are shown on the new tab page. The problem is that if top sites are not show on the new tab page we don't have access to that list and instead we show the old history list. If possible we should find a way to access the activity stream top site list for display in the address bar even when they are not shown on the new tab page. This way the sites shown with the feature always come from the same data source and enables users to have control over them.

What about users who aren't interested in "top sites"?
Personally, I don't want to see them either on a new tab OR when I focus on the address field.

Comment 3

[Harry Twyford]

Attachment: Bug 1623666 - Always show Top Sites in the Urlbar on empty searches. r?dao

Depends on D75603

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/82c5e2ef41df
Always show Top Sites in the Urlbar on empty searches. r=dao

Comment 5

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/82c5e2ef41df