1623767 - Clippy lint leaves tons of untracked files in the repo

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, defect, P3)

Description

[Andrew Halberstadt [:ahal]]

STR:

$ hg status
$ ./mach lint -l clippy
$ hg status
? gfx/webrender_bindings/Cargo.lock
? gfx/webrender_bindings/target/.rustc_info.json
? gfx/webrender_bindings/target/debug/.cargo-lock
... and over 3300 more ...

Maybe we can configure clippy not to write these files, or write them to a temporary directory?

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Good first bug, not trivial but should not be too hard.
Happy to mentor it. I will fix it otherwise

Comment 2

[Tania Batieva [:undef1nd]]

Heya, it looks interesting to me.
I'd like to give it a try. Could you please tell me where I should start from?
Thanks.

Comment 3

[Sylvestre Ledru [:Sylvestre]]

you should look at clippy's options to see if there is an autoremove or run a clean option from clippy :)

Comment 4

[Tania Batieva [:undef1nd]]

Thanks :-)

By default clippy does not seems to create any files after its run, so I was wondering what options it uses now.
As far as I understand clippy command with all the options are generated in here https://hg.mozilla.org/mozilla-central/file/tip/tools/lint/clippy/__init__.py or not really?

Comment 5

[Sylvestre Ledru [:Sylvestre]]

Correct, the args are defined here:
https://searchfox.org/mozilla-central/source/tools/lint/clippy/__init__.py#153-158

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Maybe doing that:
https://searchfox.org/mozilla-central/source/tools/lint/clippy/__init__.py#188-191
again would be enough?

Comment 7

[Tania Batieva [:undef1nd]]

So I got it: clippy leaves build artefacts after its run. Those can be removed with cargo clean after clippy execution.
But there's another problem: it also leaves Cargo.lock, which may or may not be missing for some packages https://searchfox.org/mozilla-central/search?q=cargo.lock thus I guess it needs to be also removed, but only where it's applicable.

Comment 8

[Tania Batieva [:undef1nd]]

Attachment: Bug 1623767 - Remove untracked files in the repo created by clippy r=sylvestre

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/899195086888
Remove untracked files in the repo created by clippy r=sylvestre

Comment 10

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/899195086888