Add rust clippy to mozlint
Categories
(Developer Infrastructure :: Lint and Formatting, enhancement, P1)
Tracking
(firefox75 fixed)
Tracking | Status | |
---|---|---|
firefox75 | --- | fixed |
People
(Reporter: bc, Assigned: Sylvestre)
References
(Depends on 4 open bugs, Blocks 1 open bug)
Details
Attachments
(2 files, 7 obsolete files)
Track work necessary to get in tree Rust linting implmented.
Comment 1•7 years ago
|
||
Just wanted to mention that I had previously looked into this, but using rustfmt (with the checkstyle option) instead: https://github.com/rust-lang-nursery/rustfmt But if the rust devs prefer clippy, we should definitely go with that. The only thing I'd ask is to consider somehow integrating this with mozlint: http://gecko.readthedocs.io/en/latest/tools/lint/index.html While rustfmt would be easy to integrate with mozlint, clippy would be trickier as it is a compiler extension. So I'm not 100% sure if integration makes sense in this case, or if we should make a brand new thing. And even if mozlint isn't the right fit for this, we could still re-use the existing |mach lint| mach command. Anyway, just something to consider. I'm not back until the 23rd, but I'd be happy to discuss/answer questions either here or via e-mail until then.
Comment 2•7 years ago
|
||
Doing some bug cleanup. Once we have clippy support for rust stable, I don't think this will need more than one bug to complete, so I'm just turning this into the bug that will implement clippy as a mozlint linter. Doing this will also automatically provide the mach command, so would make bug 1361343 invalid.
Updated•7 years ago
|
Updated•6 years ago
|
Assignee | ||
Updated•5 years ago
|
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 3•5 years ago
|
||
clippy cannot run on a single file. it needs to build the file
It can be built using:
cargo clippy --manifest-path js/src/wasm/cranelift/Cargo.toml
Assignee | ||
Comment 4•4 years ago
|
||
Assignee | ||
Comment 5•4 years ago
|
||
Depends on D58248
Assignee | ||
Comment 6•4 years ago
|
||
Assignee | ||
Comment 7•4 years ago
|
||
Depends on D58250
Assignee | ||
Comment 8•4 years ago
|
||
Depends on D58251
Updated•4 years ago
|
Updated•4 years ago
|
Assignee | ||
Comment 9•4 years ago
|
||
Depends on D58252
Assignee | ||
Comment 10•4 years ago
|
||
Otherwise, cargo isn't installed
Depends on D58267
Assignee | ||
Comment 11•4 years ago
|
||
Depends on D58250
Comment 12•4 years ago
|
||
Comment on attachment 9117786 [details]
Bug 1361341 - Add clippy in the mozlint docker image
Revision D58251 was moved to bug 1578058. Setting attachment 9117786 [details] to obsolete.
Comment 13•4 years ago
|
||
Comment on attachment 9117787 [details]
Bug 1361341 - Run clippy in taskcluster
Revision D58252 was moved to bug 1578058. Setting attachment 9117787 [details] to obsolete.
Comment 14•4 years ago
|
||
Comment on attachment 9117813 [details]
Bug 1361341 - TC: Create a new lint/rust category
Revision D58267 was moved to bug 1578058. Setting attachment 9117813 [details] to obsolete.
Updated•4 years ago
|
Comment 15•4 years ago
|
||
Comment on attachment 9117814 [details]
Bug 1578058 - Ride along: move the mozlint task in the file with the same name
Revision D58268 was moved to bug 1578058. Setting attachment 9117814 [details] to obsolete.
Updated•4 years ago
|
Updated•4 years ago
|
Updated•4 years ago
|
Updated•4 years ago
|
Comment 16•4 years ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/066a58eea385 Add rust clippy to mozlint r=ahal https://hg.mozilla.org/integration/autoland/rev/76d91acac82c Create the list of supported/unsupported directory with clippy r=ahal
Comment 17•4 years ago
|
||
Backed out 4 changesets (bug 1361341, bug 1578058) for mozilint failure at test_clippy.py
Backout: https://hg.mozilla.org/integration/autoland/rev/f72cd435a4cfb1dce6714580f6f6f4d622b7f717
Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=76d91acac82cab17165f838fec297ab2cb1936b0
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=288821237&repo=autoland&lineNumber=559
Comment 18•4 years ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a63ccd650889 Add rust clippy to mozlint r=ahal
Comment 19•4 years ago
|
||
Backed out changeset a63ccd650889 (bug 1361341) for causing mozlint failures
https://hg.mozilla.org/integration/autoland/rev/6f4f37881859373b597115ab621fff145b589d14
push that caused the backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=288888131&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=a63ccd65088995da39af4189d76972d95757e660
Assignee | ||
Comment 20•4 years ago
|
||
Instead of python.yml
Otherwise, it is getting the incorrect docker image (without rust).
And it makes sense that the mozlint job is next to the other tasks
Depends on D58293
Updated•4 years ago
|
Comment 21•4 years ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1131a9b0f8c0 Add rust clippy to mozlint r=ahal https://hg.mozilla.org/integration/autoland/rev/2a33639bf079 Create the list of supported/unsupported directory with clippy r=ahal
Comment 22•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1131a9b0f8c0
https://hg.mozilla.org/mozilla-central/rev/2a33639bf079
Updated•2 years ago
|
Description
•