Closed Bug 1623820 Opened 2 months ago Closed 2 months ago

make image-orientation initial value be from-image in Nightly only

Categories

(Core :: Layout: Images, Video, and HTML Frames, task, P1)

task

Tracking

()

RESOLVED FIXED
Tracking Status
firefox75 --- unaffected
firefox76 + fixed
firefox77 + fixed

People

(Reporter: heycam, Assigned: heycam)

References

Details

(Keywords: site-compat)

Attachments

(3 files)

No description provided.

Changing the priority to p1 as the bug is tracked by a release manager for the current beta.
See What Do You Triage for more information

Priority: P3 → P1
Keywords: site-compat

This was already backed out from beta, so no need to track for 75.

Depends on: 1607667
Assignee: nobody → cam

We'll let this ride the trains once Chrome 81 is set to be released.

Landing this despite the soft freeze since the bulk of the image-orientation changes are only going to land after it, and we want to keep the image-orientation initial value change from reaching Beta.

Pushed by cmccormack@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/84b4182ce880
Part 1: Add support for pref-controlled initial values. r=emilio
https://hg.mozilla.org/integration/autoland/rev/4126098473d5
Part 2: Make image-orientation initial value change be Nightly only. r=emilio
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
Target Milestone: Future → ---

I missed that this was backed out from beta. Try run for patches to uplift to beta again: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0bd185900ef0e98c51dda677c4c8800980055457

Flags: needinfo?(cam)

Approval Request Comment
[Feature/Bug causing the regression]: bug 1627512
[User impact if declined]: image-orientation initial value would be changed to automatically re-orient JPEG images, without corresponding changes to canvas drawImage, CSS images, etc.
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: -
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: The Part 1 patch on Phabricator, which can be uplifted unchanged.
[Is the change risky?]: no
[Why is the change risky/not risky?]: This reverts the image-orientation initial value change.
[String changes made/needed]: -

Attachment #9141605 - Flags: approval-mozilla-beta?
Comment on attachment 9141605 [details] [diff] [review]
Part 2 patch for uplift

Avoids shipping a feature which isn't ready yet. Approved for 76.0b7.
Attachment #9141605 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.