1623820 - make image-orientation initial value be from-image in Nightly only

Status: RESOLVED FIXED

(Core :: Layout: Images, Video, and HTML Frames, task, P1)

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Changing the priority to p1 as the bug is tracked by a release manager for the current beta.
See What Do You Triage for more information

Comment 2

[Cameron McCormack (:heycam)]

This was already backed out from beta, so no need to track for 75.

Comment 3

[Cameron McCormack (:heycam)]

Attachment: Bug 1623820 - Part 1: Add support for pref-controlled initial values.

Comment 4

[Cameron McCormack (:heycam)]

Attachment: Bug 1623820 - Part 2: Make image-orientation initial value change be Nightly only.

We'll let this ride the trains once Chrome 81 is set to be released.

Comment 5

[Cameron McCormack (:heycam)]

Landing this despite the soft freeze since the bulk of the image-orientation changes are only going to land after it, and we want to keep the image-orientation initial value change from reaching Beta.

Comment 6

[Cameron McCormack (:heycam)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=211575a0a407f4f0aa4a54bd5b6fe8fa15414c85

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/84b4182ce880
Part 1: Add support for pref-controlled initial values. r=emilio
https://hg.mozilla.org/integration/autoland/rev/4126098473d5
Part 2: Make image-orientation initial value change be Nightly only. r=emilio

Comment 8

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/84b4182ce880
https://hg.mozilla.org/mozilla-central/rev/4126098473d5

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out from mozilla-beta (Gecko 76) due to bug 1627512: https://hg.mozilla.org/releases/mozilla-beta/rev/b4ef8571957b03316302e9dd21979a0d2612f648

Comment 10

[Cameron McCormack (:heycam)]

I missed that this was backed out from beta. Try run for patches to uplift to beta again: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0bd185900ef0e98c51dda677c4c8800980055457

Comment 11

[Cameron McCormack (:heycam)]

Attachment: Part 2 patch for uplift

Approval Request Comment
[Feature/Bug causing the regression]: bug 1627512
[User impact if declined]: image-orientation initial value would be changed to automatically re-orient JPEG images, without corresponding changes to canvas drawImage, CSS images, etc.
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: -
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: The Part 1 patch on Phabricator, which can be uplifted unchanged.
[Is the change risky?]: no
[Why is the change risky/not risky?]: This reverts the image-orientation initial value change.
[String changes made/needed]: -

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9141605 [details] [diff] [review]
Part 2 patch for uplift

Avoids shipping a feature which isn't ready yet. Approved for 76.0b7.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/857d43ca92cb
https://hg.mozilla.org/releases/mozilla-beta/rev/10263f732760