1623906 - Replace React props to show/hide the box model highlighter with Redux thunks

Status: RESOLVED FIXED

(DevTools :: Inspector, task, P3)

Description

[Razvan Caliman [:rcaliman]]

There's a lot of React prop-drilling for passing onShowBoxModelHighlighterForNode() from the inspector client down to components in the Layout panel (GridItem/FlexItem), AnimationPanel and the CompatibilityPanel.

https://searchfox.org/mozilla-central/search?path=&q=onShowBoxModelHighlighterForNode

Perhaps it would be better for the highlighter to be accessible by dispatching a Redux action (ex: "SHOW_HIGHLIGTER" / "HIDE_HIGHLIGHTER") against to the shared store between the inspector client and these panels.

Comment 1

[Razvan Caliman [:rcaliman]]

Attachment: Bug 1623906 - [devtools] Dispatch thunks from Flexbox panel React components to highlight nodes r=nchevobbe,gl,jdescottes

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:rcaliman, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 3

[Razvan Caliman [:rcaliman]]

The work for this bug is incomplete.

There is another patch in the works. It depends somewhat on bug 1646028 (not a real blocker, but would require duplicate work after it lands).
I will pick up work on this again after bug 1646028 lands.

Comment 4

[Razvan Caliman [:rcaliman]]

Attachment: Bug 1623906 - [devtools] Dispatch thunks from Box Model panel React components to show/hide the Box Model Highlighter

Depends on D79556

Comment 5

[Razvan Caliman [:rcaliman]]

Attachment: Bug 1623906 - [devtools] Dispatch thunks from Compatibility panel React components to show/hide the Box Model Highlighter

Depends on D95033

Comment 6

[Razvan Caliman [:rcaliman]]

Attachment: Bug 1623906 - [devtools] Dispatch thunks from Animation panel React components to show/hide the Box Model Highlighter

Depends on D95034

Comment 7

[Razvan Caliman [:rcaliman]]

Attachment: Bug 1623906 - [devtools] Dispatch thunks from Grid panel React components to show/hide the Box Model Highlighter

Depends on D95035

Comment 8

[Chris Peterson [:cpeterson]]

Tracking dt-fission-m2-mvp bugs for Fission Beta milestone (M7).

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/78d0de3437ab
[devtools] Dispatch thunks from Flexbox panel React components to highlight nodes r=gl,jdescottes,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/362bad2b7311
[devtools] Dispatch thunks from Box Model panel React components to show/hide the Box Model Highlighter r=gl
https://hg.mozilla.org/integration/autoland/rev/bc7e021e8d98
[devtools] Dispatch thunks from Compatibility panel React components to show/hide the Box Model Highlighter r=daisuke
https://hg.mozilla.org/integration/autoland/rev/2af3b0ee91ac
[devtools] Dispatch thunks from Animation panel React components to show/hide the Box Model Highlighter r=daisuke
https://hg.mozilla.org/integration/autoland/rev/92d23f0ea155
[devtools] Dispatch thunks from Grid panel React components to show/hide the Box Model Highlighter r=gl

Comment 10

[Atila Butkovits]

Backed out for node failures.

Backout link: https://hg.mozilla.org/integration/autoland/rev/046b394f54c39cf6b09233c26ae48d1746bceeb5

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=92d23f0ea155f5067c7aacb7e6d1b625c67a32e1&searchStr=node&selectedTaskRun=UXPhWvHWRkqrJ5HXZi1j5A.0

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=320135864&repo=autoland&lineNumber=636

Comment 11

[Razvan Caliman [:rcaliman]]

Fixed test snapshot, queuing for landing again

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3fda2292a5f3
[devtools] Dispatch thunks from Flexbox panel React components to highlight nodes r=gl,jdescottes,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/f14a419b4c60
[devtools] Dispatch thunks from Box Model panel React components to show/hide the Box Model Highlighter r=gl
https://hg.mozilla.org/integration/autoland/rev/7ff5a03e37d0
[devtools] Dispatch thunks from Compatibility panel React components to show/hide the Box Model Highlighter r=daisuke
https://hg.mozilla.org/integration/autoland/rev/492a90355e0d
[devtools] Dispatch thunks from Animation panel React components to show/hide the Box Model Highlighter r=daisuke
https://hg.mozilla.org/integration/autoland/rev/dabd16270a48
[devtools] Dispatch thunks from Grid panel React components to show/hide the Box Model Highlighter r=gl

Comment 13

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/3fda2292a5f3
https://hg.mozilla.org/mozilla-central/rev/f14a419b4c60
https://hg.mozilla.org/mozilla-central/rev/7ff5a03e37d0
https://hg.mozilla.org/mozilla-central/rev/492a90355e0d
https://hg.mozilla.org/mozilla-central/rev/dabd16270a48