Closed Bug 1624057 Opened 4 years ago Closed 4 years ago

Update mp4parse-rust to 63ca8c6

Categories

(Core :: Audio/Video: Playback, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla76
Tracking Status
firefox76 --- fixed

People

(Reporter: jbauman, Assigned: jbauman)

References

Details

Attachments

(1 file)

This brings in the changes necessary for basic AVIF parsing (see bug 1443863).

Revision 1607f3c is not the tip of the master branch currently, but there is likely some further work to be done as follow up on the most recent commits, so I think I'll save that update for later.

Additionally, we should update the way we pull mp4parse-rust updates, but that's a separate issue (see bug 1624056) and lower priority that getting some experimental AVIF support out.

Assignee: nobody → jbauman
Priority: -- → P1

On second thought, we should only update to revision 63ca8c6, as going any further starts to include more changes to allocation fallibility that are likely to be obviated by the creation of shared rust fallible allocation (issue forthcoming).

Summary: Update mp4parse-rust to 1607f3c → Update mp4parse-rust to 63ca8c6

Also update the update-rust.sh script in a couple ways:

  • Stop copying the source for mp4parse_fallible into the tree; use crates.io
  • Include submodules in mp4parse-rust checkout; needed for tests
  • Exclude unnecessary build.rs from mp4parse_fallible, it was causing problems
Pushed by ccoroiu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7ec1ce6883d6
Update mp4parse-rust to 63ca8c6. r=kinetik
Regressions: 1625059
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: