Closed
Bug 1624287
Opened 4 years ago
Closed 4 years ago
Remove obsolete methods and events from Walker front and spec
Categories
(DevTools :: Inspector, task, P1)
DevTools
Inspector
Tracking
(Fission Milestone:M6c, firefox76 fixed)
Tracking | Status | |
---|---|---|
firefox76 | --- | fixed |
People
(Reporter: rcaliman, Assigned: rcaliman)
References
Details
(Whiteboard: dt-fission-m2-mvp)
Attachments
(1 file)
The walker front and spec have obsolete methods and events relating to the node picker and highlighter:
walker.pick()
is no longer used. The node picker client calls the highlighter front directly.walker.cancelPick()
andwalker.highlight()
do not have an implementation in the front or actor anymore.- "highlighter-ready" event is no longer used since Firefox 70
The walker actor and front still emit node-picker events on behalf of the highlighter. This will be refactored in bug 1607756 by co-locating node-picking behavior and emitting of events into the upcoming node picker actor and front, thereby relieving the walker actor and front from acting as a proxy.
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 1•4 years ago
|
||
Assignee | ||
Updated•4 years ago
|
Priority: P3 → P2
Whiteboard: dt-fission-m2-mvp
Pushed by rcaliman@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f40f22f7220a Cleanup obsolete Walker front and spec methods and events. r=jdescottes
Updated•4 years ago
|
Priority: P2 → P1
Comment 3•4 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox76:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 76
Comment 4•4 years ago
|
||
Tracking dt-fission-m2-mvp bugs for Fission Nightly milestone (M6c)
Fission Milestone: --- → M6c
You need to log in
before you can comment on or make changes to this bug.
Description
•