1624380 - mach bootstrap does not update nasm; ERROR: nasm 2.14 or greater is required for AV1 support.

Status: RESOLVED FIXED

(Firefox Build System :: Bootstrap Configuration, defect)

Description

[Markus Stange [:mstange]]

mach bootstrap on macOS does not seem to upgrade nasm via homebrew. Our nasm dependency recently increased to version 2.14 in bug 1622356.

mstange@Markuss-MacBook-Pro mozilla % MOZCONFIG=.mozconfig-opt mach build
[...]
 0:35.75 checking for nodejs... /Users/mstange/.mozbuild/node/bin/node (10.19.0)
 0:35.76 ERROR: nasm 2.14 or greater is required for AV1 support. Either install nasm or add --disable-av1 to your configure options.
 0:35.82 *** Fix above errors and then restart with               "./mach build"
 0:35.82 make: *** [configure] Error 1
mstange@Markuss-MacBook-Pro mozilla % which nasm
/usr/local/bin/nasm
mstange@Markuss-MacBook-Pro mozilla % nasm --version
NASM version 2.13.03 compiled on Feb  8 2018
mstange@Markuss-MacBook-Pro mozilla % mach bootstrap
[...]

Please choose the version of Firefox you want to build:
  1. Firefox for Desktop Artifact Mode
  2. Firefox for Desktop
  3. GeckoView/Firefox for Android Artifact Mode
  4. GeckoView/Firefox for Android
Your choice: 2

Looks like you have Homebrew installed. We will install all required packages via Homebrew.

Your version of Mercurial (5.1) is sufficiently modern.
Your version of Python (2.7.17) is new enough.
Your version of Rust (1.41.0) is too old.
Found rustup. Will try to upgrade.
[...]

Your system should be ready to build Firefox for Desktop!

mstange@Markuss-MacBook-Pro mozilla % MOZCONFIG=.mozconfig-opt mach build
[...]
 0:11.08 checking for nodejs... /Users/mstange/.mozbuild/node/bin/node (10.19.0)
 0:11.08 ERROR: nasm 2.14 or greater is required for AV1 support. Either install nasm or add --disable-av1 to your configure options.
 0:11.13 *** Fix above errors and then restart with               "./mach build"
 0:11.13 make: *** [configure] Error 1

Comment 1

[Markus Stange [:mstange]]

Running brew upgrade nasm fixed it, but it would be nice if mach bootstrap did it for me.

Comment 2

[Ricky Stewart]

I think the "right" way to do this would be to run brew update before the installs and then brew upgrade $PACKAGE for every PACKAGE that we installed? I can write a quick patch to do that.

Comment 3

[Mitchell Hentges [:mhentges] 🦀]

Attachment: Bug 1624380: upgrades brew packages if they're out-of-date r?rstewart

./mach bootstrap prepares your environment for a build, and it was preparing "brew" dependencies properly if they weren't installed.
However, if a package was out-of-date, it was ignored by the bootstrapping logic since it was already "installed".

This change ensures that brew update is run, and updates any out-of-date packages that are requested.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/306fcf2f0194
upgrades brew packages if they're out-of-date r=rstewart

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/306fcf2f0194