1622356 - dav1d 0.6.0 import requires nasm 2.14.02 or higher

Status: RESOLVED FIXED

(Firefox Build System :: Toolchains, enhancement, P3)

Description

[Michael Froman [:mjf]]

We need the base-toolchains to require at minimum nasm 2.14 in order to import the 0.6.0 version of dav1d or they fail to build.

Comment 1

[Michael Froman [:mjf]]

Base toolchain failure example: https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=292759496&revision=e2255b7646b82efcd9c34ec437bf9129979e54df

Comment 2

[Michael Froman [:mjf]]

:froydnj, do you know who needs to approve making this change? Is this as simple as changing all the occurrences of linux64-nasm-2.13.02 to linux64-nasm in taskcluster/ci/build/linux.yml?

Comment 3

[Nathan Froyd [:froydnj]]

(In reply to Michael Froman [:mjf] from comment #2)

:froydnj, do you know who needs to approve making this change? Is this as simple as changing all the occurrences of linux64-nasm-2.13.02 to linux64-nasm in taskcluster/ci/build/linux.yml?

I think any build peer can approve this change. It's not obvious to me why we even have two different versions of nasm; bug 1520163 added both versions without (so far as I can tell) any discussion of needing different versions. Debian stable has nasm 2.14 and Debian oldstable has a backport for 2.14, so I think we are OK on that front?

I don't think we want to change linux64-nasm-2.13.02 dependencies directly to linux64-nasm, because then we'd lose the distinction between "commonly used version" and "minimum supported version". I think we'd be better off changing the linux64-nasm-2.13.02 job to linux64-nasm-2.14.02 and updating its label and fetch target appropriately. I would say that we'd want to change the check in configure...but we don't actually check the nasm version in toolchain.configure, so bonus points if you actually added a check.

Comment 4

[Mike Hommey [:glandium]]

(In reply to Nathan Froyd [:froydnj] from comment #3)

Debian oldstable has a backport for 2.14

It doesn't.

but we don't actually check the nasm version in toolchain.configure, so bonus points if you actually added a check.

We do, where it matters, in toolkit/moz.configure.

Comment 5

[Nathan Froyd [:froydnj]]

(In reply to Mike Hommey [:glandium] from comment #4)

(In reply to Nathan Froyd [:froydnj] from comment #3)

Debian oldstable has a backport for 2.14

It doesn't.

It has nasm-mozilla, which I presume is good enough:

https://packages.debian.org/search?keywords=nasm&searchon=names&suite=oldstable&section=all

but we don't actually check the nasm version in toolchain.configure, so bonus points if you actually added a check.

We do, where it matters, in toolkit/moz.configure.

I failed to grep properly for nasm_version, silly me.

Comment 6

[Michael Froman [:mjf]]

Attachment: Bug 1622356 - change minimum supported linux nasm to 2.14.02. r?froydnj!

Dav1d 0.6.0 requires nasm 2.14.02.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/61b498aa3e35
change minimum supported linux nasm to 2.14.02. r=froydnj

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/61b498aa3e35