1624388 - Properly expose default browser agent build flag to installer

Status: RESOLVED FIXED

(Toolkit :: Default Browser Agent, defect, P1)

Description

[Molly Howell (she/her) (no longer active)]

The summary kind of says it all; I forgot to copy the build flag for enabling the default browser agent over into the preprocessor defines for the installer build, so the installers never think the agent is enabled, so they never try to register its scheduled task.

Comment 1

[Molly Howell (she/her) (no longer active)]

Attachment: Bug 1624388 - Properly expose default browser agent build flag to installer. r=bytesized

Also fix two other installer problems that were getting missed because of this:
one build error in PostUpdate and one use of an uninitialized value in the
installer, causing it to record that it had not registered the task when it had.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/114a18c41aa9
Properly expose default browser agent build flag to installer. r=bytesized,agashlin

Comment 3

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/114a18c41aa9

Comment 4

[Molly Howell (she/her) (no longer active)]

Comment on attachment 9135208 [details]
Bug 1624388 - Properly expose default browser agent build flag to installer. r=bytesized

Beta/Release Uplift Approval Request

• User impact if declined: Like bug 1624047, this is an important fix for the default browser agent (bug 1602463) and will need to be uplifted along with it if that uplift is approved.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): These are small fixes and I've verified them locally and in Nightly.
• String changes made/needed:

Comment 5

[Julien Cristau [:jcristau] (back April 22)]

Comment on attachment 9135208 [details]
Bug 1624388 - Properly expose default browser agent build flag to installer. r=bytesized

approved for 75.0b9

Comment 6

[Julien Cristau [:jcristau] (back April 22)]

https://hg.mozilla.org/releases/mozilla-beta/rev/6463c4cee996