Closed
Bug 1624473
Opened 5 years ago
Closed 5 years ago
Don't use "mozilla/TypeTraits.h" in generated binding code
Categories
(Core :: DOM: Core & HTML, task)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla76
Tracking | Status | |
---|---|---|
firefox76 | --- | fixed |
People
(Reporter: Waldo, Assigned: Waldo)
Details
Attachments
(1 file)
No description provided.
Assignee | ||
Comment 1•5 years ago
|
||
Updated•5 years ago
|
Attachment #9135270 -
Attachment description: Bug 1624473 - Use #include <type_traits> in Codegen.py, not #include "mozilla/TypeTraits.h". r=emilio! → Bug 1624473 - Use #include <type_traits> in Codegen.py instead of #include "mozilla/TypeTraits.h", as a step toward removing the latter now that it's no longer needed. r=emilio!
Assignee | ||
Comment 2•5 years ago
|
||
FWIW as far as context, now that #include <type_traits>
is fully usable, there's no reason for #include "mozilla/TypeTraits.h"
to be used, and so current users should switch over.
Currently https://searchfox.org/mozilla-central/search?q=mozilla/TypeTraits.h gives me 824 results -- and the vast majority are in generated code from DOM bindings. So knock out the contributions from this one, and you knock out upwards of 80% of all users at once -- making the remaining users easier to view and scroll through. Quick'n'easy hit, good starting point.
(I don't intend to systematically change over all existing uses, but spurred on by bug 1623957 I might do one or two areas of particular relevance to me.)
Pushed by jwalden@mit.edu:
https://hg.mozilla.org/integration/autoland/rev/6f7be2b2dd51
Use #include <type_traits> in Codegen.py instead of #include "mozilla/TypeTraits.h", as a step toward removing the latter now that it's no longer needed. r=emilio
Comment 4•5 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox76:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
You need to log in
before you can comment on or make changes to this bug.
Description
•