1624490 - Allow declared segments to contain ref.null

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, defect, P3)

Description

[Ryan Hunt [:rhunt]]

The spec allows for declared segments to contain null [1], but we don't allow this. I believe the reason I didn't was that I couldn't see a use-case for it, but I can't really see any argument against allowing it either.

[1] https://webassembly.github.io/reference-types/core/valid/modules.html#element-segments

Comment 1

[Ryan Hunt [:rhunt]]

Attachment: Bug 1624490 - Allow ref.null in declared segments. r?lth

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b89a4862242c
Allow ref.null in declared segments. r=lth

Comment 3

[Andrei Ciure[:aciure]]

Backed out changeset b89a4862242c (bug 1624490) for causing CompileError asertion failures
https://hg.mozilla.org/integration/autoland/rev/cdf202c2682eccdb9781145451cb707ec157db9d

push that caused the backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=294699981&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=b89a4862242cf93166205e15ccdff8e9c04de9b5&failure_classification_id=2

Comment 4

[Ryan Hunt [:rhunt]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7087bea46fad79610af946749a6407ee39f88f9d

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f8086519b208
Allow ref.null in declared segments. r=lth

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/f8086519b208