162450 - Location bar URL completion could search names/titles of bookmarks and history items

Status: RESOLVED FIXED

(Camino Graveyard :: Location Bar & Autocomplete, enhancement, P4)

Description

[Gary Yuen]

Address completion could search bookmarks and thus become bookmark completion or
another way to select a bookmark.

Comment 1

[Greg K.]

Does Mozilla already offer this capability? If not, it might be best to
request/create it there first.

Comment 2

[Winnie Lam]

Gary, would this be a dupe of bug 159497?

Comment 3

[Gary Yuen]

this would be a different type of request. Shortcuts or aliases like galeon are
nice but a bookmark  search/completion like a url history completion already
there would be nice.  So if I started to type goo and there was a bookmark
titled google, it would complete it like url histories currently work

Comment 4

[Max Horn]

Just FYI, IE 5 on Mac OS X does this (and I find it extremly useful).

Comment 5

[Matthew Cline]

Seems to be the same as Browser bug 155320

Comment 6

[S Woodside]

Dupe of Bug 101642 ? If this gets fixed in the browser do we get it in chimera
automatically?

Re comment #5, no, that deals with adding a used bookmark to the history.

Comment 7

[sairuh (rarely reading bugmail)]

->sfraser. seems similar to an rfe i filed to add quicksearch to the bookmarks
(and history) sidebar...

Comment 8

[S Woodside]

Just to be completely clear, this bug is to add the Name of all of your
bookmarks to the list of autocompletion shortcuts/names/whatever.
Autocompleting based on the URL of the bookmark is Bug 166288

Comment 9

[Jasper]

Then isn't this bug a duplicate of Bug 166288?

Comment 10

[S Woodside]

updating summary to clarify differnce.

Comment 11

[Samuel Sidler (old account; do not CC)]

This seems like something that should be done for 1.0? Is it hard?

Targeting for 1.0, priority 4.

Comment 12

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

*** Bug 190184 has been marked as a duplicate of this bug. ***

Comment 13

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Do we want it to complete from page titles in history, too?

Will there be any user control in this (autocomplete from urls only,
autocomplete from page/bookmark titles only, autocomplete from both)?  I'm not
fond of autocompleting from bookmark/page titles, but it's not a big issue.

Finally, FYI, Camino's own bug to autocomplete from bookmark *URLs* (Bug 166288)
was duped against trunk bug 101642, which is currently assigned to no one...

Comment 14

[Yuan Qi]

It's a good idea to fix the bug on the trunk instead writing our own
implementation. We might want to write a patch against the 1.8 branch and port
the patch to the trunk later.

Comment 15

[Simon Fraser [no longer active]]

(In reply to comment #14)
> It's a good idea to fix the bug on the trunk instead writing our own
> implementation.

We can't share with FF (if that's what you mean) because our bookmarks impl is
different.

> We might want to write a patch against the 1.8 branch and port
> the patch to the trunk later.

The camino code is almost identical between the trunk and branch at the moment.

Comment 16

[Samuel Sidler (old account; do not CC)]

Simon, is there any chance this will be ready by 1.0?

Comment 17

[Mike Pinkerton (not reading bugmail)]

no way this can make 1.0

Comment 18

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Mass un-setting milestone per 1.6 roadmap.

Filter on RemoveRedonkulousBuglist to remove bugspam.

Developers: if you have a patch in hand for one of these bugs, you may pull the bug back to 1.6 *at that point*.

Comment 19

[Dan Weber]

Attachment: Patch 1

Comment 20

[Stuart Morgan]

Comment on attachment 389027 [details] [diff] [review]
Patch 1

I'm pretty sure we want to do word-prefix matching, rather than arbitrary substring matching, for this to feel right. (Specifically, I think just a predicate starting with \b is probably enough; we could get really fancy and tokenize, but let's wait and see if that seems worthwhile after using the simpler form for a while.)

Codewise this looks good though if people disagree with me though :)

Comment 21

[Dan Weber]

Attachment: Patch 2

Based on my own personal use, I think it is useful to be able to type in an arbitrary word you remember from a title and have that match. However, I don't think that a tokenized search like Firefox 3 uses is all that useful. I'm not going to type more than one word--or more than a couple letters--to find the right URL. Anyway, patch 2 uses an anchored search, so the match has to happen at the beginning of the title.

Comment 22

[Dan Weber]

Attachment: Patch 3

Matches search string only if it's at the beginning of a word in the title.

Comment 23

[Stuart Morgan]

Comment on attachment 389199 [details] [diff] [review]
Patch 3

Third time's the charm; r=me

Comment 24

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 389199 [details] [diff] [review]
Patch 3

sr=pink

Comment 25

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Landed on cvs trunk.  (This was the 16th oldest open Camino bug.)