1624599 - Stop using `-moz-appearance: menuitem` for menupopup scrollbuttons on Mac

Status: RESOLVED FIXED

(Toolkit :: Themes, task, P2)

Description

[Dão Gottwald [:dao]]

See https://phabricator.services.mozilla.com/D67678#inline-403049

We might want to do this across platforms as I don't think what we do on Linux and Windows at the moment is guided by platform convention.

Comment 1

[Tim Nguyen :ntim]

Attachment: scrollbuttons-macos.diff

Just attaching the patch from Phabricator so it doesn't get lost. Probably can't ship the way it is though.

mstange provided a very useful CodePen as well: https://codepen.io/mstange/pen/abOROgN

Comment 2

[Markus Stange [:mstange]]

I'll try to finish this up. But I'll only do it for macOS because I'm not set up to test other platforms at the moment.

Comment 3

[Markus Stange [:mstange]]

Attachment: Bug 1624599 - When menu arrow scroll buttons overlap the menu contents, use overflow:hidden to clip away the contents underneath, rather than relying on -moz-appearance tricks. r=dao

Comment 4

[Markus Stange [:mstange]]

This effect could in fact easily be made cross-platform if the styles were moved to a shared place. I just didn't do it because I didn't know where that shared place would be. But I'm sure for somebody who's more familiar with the code it's an easy change to make.

The original patch in this bug included two changes to exportparts attributes. In my testing, things worked even without those changes, so I took them out. Should I put them back?

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5dea570231ee
When menu arrow scroll buttons overlap the menu contents, use overflow:hidden to clip away the contents underneath, rather than relying on -moz-appearance tricks. r=dao

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/5dea570231ee