1624819 - Maybe remove TaskCategory.

Status: RESOLVED FIXED

(Core :: XPCOM, task)

Description

[Andreas Farre [:farre]]

Bug 1620594 is removing TabGroup and SystemGroup, and by doing so removing the distinct event targets for different task categories.

TabGroup was responsible for managing the different task category event targets, but since we never started using the abstract threads we were planning to use to be able to schedule TabGroups we never used event targets that behaved differently than dispatching to the main thread event target.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1624819 - Remove TaskCategory and other quantum dom remnants. r=smaug,farre

Sorry this is not a particularly easy patch to review. But it should be
mostly straight-forward.

I kept Document::Dispatch mostly for convenience, but could be
cleaned-up too / changed by SchedulerGroup::Dispatch. Similarly maybe
that can just be NS_DispatchToMainThread if we add an NS_IsMainThread
check there or something (to preserve shutdown semantics).

Comment 2

[Karl Tomlinson (:karlt)]

TaskCategory removal perhaps did not depend on the removal of about:performance, but the removal of the per-tab cpu usage metrics means that per-window event targets no longer have value, and the patch here is intending to remove those.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/324cc7d374d1
Remove TaskCategory and other quantum dom remnants. r=smaug,media-playback-reviewers,credential-management-reviewers,cookie-reviewers,places-reviewers,win-reviewers,valentin,mhowell,sgalich,alwu

Comment 4

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/324cc7d374d1