1620594 - Completely remove TabGroup.

Status: RESOLVED FIXED

(Core :: DOM: Navigation, task)

Comment 1

[Andreas Farre [:farre]]

Added a separate bug for the final stages of TabGroup removal to separate it from the remaining work.

Comment 2

[Andreas Farre [:farre]]

Attachment: Bug 1620594 - Part 7: Remove TabGroup and SystemGroup. r=nika!

Removing TabGroup directly implies that there is now only one
SchedulerGroup, namely the SystemGroup. Because of this we can at
every point where TabGroup does a dispatch, gets and event target,
etc, switch to SystemGroup instead.

TabGroup never really made any difference in which thread something go
dispatched to. This was the intended use, but development of TabGroups
with abstract main threads never made it that far. The good thing is
that thish makes it safe to default to the SystemGroup.

Timers for setTimeout and workers were the sole users of wrapped and
throttled event targets, that those throttled queues have been moved
to the BrowsingContextGroup and are now accessed explicitly.

DocGroups have also been moved to BrowsingContextGroup.

Comment 4

[Andreas Farre [:farre]]

Attachment: Bug 1620594 - Part 1: Rework NS_ReleaseOnMainThreadSystemGroup. r=nika!

To be able to remove SystemGroup, NS_ReleaseOnMainThreadSystemGroup
needs to have its dependency on SystemGroup removed. Since all
releases using SystemGroup would've released on the main thread anyway
we can safely replace NS_ReleaseOnMainThreadSystemGroup with
NS_ReleaseOnMainThread.

Depends on D64390

Comment 5

[Andreas Farre [:farre]]

Attachment: Bug 1620594 - Part 2: Use SchedulerGroup::Dispatch instead of SystemGroup::Dispatch. r=nika!

Depends on D67631

Comment 6

[Andreas Farre [:farre]]

Attachment: Bug 1620594 - Part 3: Use default target for timers using SystemGroup. r=nika!

Depends on D67632

Comment 7

[Andreas Farre [:farre]]

Attachment: Bug 1620594 - Part 4: Remove SetEventTargetForActor with SystemGroup target. r=nika!

Depends on D67633

Comment 8

[Andreas Farre [:farre]]

Attachment: Bug 1620594 - Part 5: Use GetMainThreadSerialEventTarget instead of SystemGroup::EventTargetFor. r=nika!

This patch also tries to remove the event target entirely if it would
default to the main thread on a null event target.

Depends on D67634

Comment 9

[Andreas Farre [:farre]]

Attachment: Bug 1620594 - Part 6: Use AbstractThread::MainThread instead of SystemGroup::AbstractThread. r=nika!

Depends on D67635

Comment 10

[Peter Van der Beken [:peterv]]

This is sort of the same as bug 1561715, so setting same Fission milestone.

Comment 11

[Andreas Farre [:farre]]

Attachment: Bug 1620594 - Part 8: Add lsan exception for DocGroup::Create. r=mccr8!

There was already an exception already for
mozilla::SchedulerGroup::CreateEventTargetFor, and this code has now
(re)moved to DocGroup as DocGroup::mEventTarget. DocGroup::mEventTarget
is created from DocGroup::Create, which is where the leak shows up now.

Depends on D65936

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4c58ef4b5ed0
Part 1: Rework NS_ReleaseOnMainThreadSystemGroup. r=nika
https://hg.mozilla.org/integration/autoland/rev/672e860442c3
Part 2: Use SchedulerGroup::Dispatch instead of SystemGroup::Dispatch. r=nika
https://hg.mozilla.org/integration/autoland/rev/7530afa936d5
Part 3: Use default target for timers using SystemGroup. r=nika
https://hg.mozilla.org/integration/autoland/rev/22cac5d2d136
Part 4: Remove SetEventTargetForActor with SystemGroup target. r=nika
https://hg.mozilla.org/integration/autoland/rev/de2dc6c4fe6f
Part 5: Use GetMainThreadSerialEventTarget instead of SystemGroup::EventTargetFor. r=nika
https://hg.mozilla.org/integration/autoland/rev/a5ad3b179c92
Part 6: Use AbstractThread::MainThread instead of SystemGroup::AbstractThread. r=nika
https://hg.mozilla.org/integration/autoland/rev/36b0646e8649
Part 7: Remove TabGroup and SystemGroup. r=nika,bas
https://hg.mozilla.org/integration/autoland/rev/9a9161243d00
Part 8: Add lsan exception for DocGroup::Create. r=mccr8

Comment 13

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/4c58ef4b5ed0
https://hg.mozilla.org/mozilla-central/rev/672e860442c3
https://hg.mozilla.org/mozilla-central/rev/7530afa936d5
https://hg.mozilla.org/mozilla-central/rev/22cac5d2d136
https://hg.mozilla.org/mozilla-central/rev/de2dc6c4fe6f
https://hg.mozilla.org/mozilla-central/rev/a5ad3b179c92
https://hg.mozilla.org/mozilla-central/rev/36b0646e8649
https://hg.mozilla.org/mozilla-central/rev/9a9161243d00

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/25b29578a146
Port bug 1620594 part 1: Change NS_ReleaseOnMainThreadSystemGroup to NS_ReleaseOnMainThread. rs=bustage-fix