1624858 - WebRender compositor disabled by blocklist when it should not be

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P2)

Description

[Andrew Osmond [:aosmond] (he/him)]

Due to:

https://searchfox.org/mozilla-central/rev/c80fa7258c935223fe319c5345b58eae85d4c6ae/widget/GfxInfoBase.cpp#861

and:

https://searchfox.org/mozilla-central/rev/c80fa7258c935223fe319c5345b58eae85d4c6ae/widget/GfxInfoBase.cpp#779

We always end up matching any blocklist rule which says NotRecentWindows10 on any version of Windows 10.

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1624858 - Fix graphics blocklist not recent Windows 10 comparison check.

Comment 2

[Andrew Osmond [:aosmond] (he/him)]

Comment on attachment 9135687 [details]
Bug 1624858 - Fix graphics blocklist not recent Windows 10 comparison check.

Beta/Release Uplift Approval Request

• User impact if declined: They won't get WebRender compositor in late beta and release as we expected.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It was on until recently with early beta. We verified the patch works with a try beta build in both the cases we don't want WebRender compositor, and in the cases we do want WebRender compositor.
• String changes made/needed:

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f498ba0dcc35
Fix graphics blocklist not recent Windows 10 comparison check. r=jrmuizel

Comment 4

[Julien Cristau [:jcristau]]

Comment on attachment 9135687 [details]
Bug 1624858 - Fix graphics blocklist not recent Windows 10 comparison check.

approved for 75.0b9

Comment 5

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/6a176a257317

Comment 6

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/f498ba0dcc35

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

This bug is tracked by a release manager but with a small severity so change it to major.
For more information, please visit auto_nag documentation.

Comment 8

[Firefox Bug Husbandry Bot]

Please specify a root cause for this bug. See :tmaity for more information.

Comment 9

[Andrew Osmond [:aosmond] (he/him)]

Testing Error: Missing Test Coverage. Since then we have been working to improve our deployment test coverage in bugs such as bug 1632259.