1624863 - Rewrite PurgeTrackerService.jsm logging to use console.createInstance

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, task, P3)

Description

[Johann Hofmann [:johannh]]

Like https://searchfox.org/mozilla-central/rev/c80fa7258c935223fe319c5345b58eae85d4c6ae/browser/modules/Sanitizer.jsm#37 which is a bit more idiomatic.

Comment 1

[aarushivij]

Hello Joahnn
Can I work on this issue?
Do we need to change this function https://searchfox.org/mozilla-central/source/toolkit/components/antitracking/PurgeTrackerService.jsm#281
as the one mentioned in the above comment?
Thanks :)
Aarushi

Comment 2

[Johann Hofmann [:johannh]]

Hey, I noticed that Erica filed bug 1624906 so this bug may be invalid if we use our own custom logging mechanism. Erica, what do you think?

If this bug is still valid it would be a good bug to work on, yes.

Comment 3

[Erica Wright [:ewright]]

We've been discussing adding permanent logging, but it looks like if it will happen it's further in the future, due to some complications. In that case, it is worth it to make this change.
Aarushi, thank you for volunteering to take this!

Comment 4

[aarushivij]

Hey Erica, just want to make sure that Do we need to change this function https://searchfox.org/mozilla-central/source/toolkit/components/antitracking/PurgeTrackerService.jsm#281
as the one mentioned in the above comment (Like https://searchfox.org/mozilla-central/rev/c80fa7258c935223fe319c5345b58eae85d4c6ae/browser/modules/Sanitizer.jsm#37 which is a bit more idiomatic.)?
Thanks
Aarushi

Comment 5

[Johann Hofmann [:johannh]]

Yeah, that sounds about right :)

Comment 6

[aarushivij]

Attachment: Bug 1624863 - Rewrite PurgeTrackerService.jsm logging to use console.createInstance r=johannh

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3e03712c2056
Rewrite PurgeTrackerService.jsm logging to use console.createInstance r=johannh

Comment 8

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/3e03712c2056