Closed Bug 1624882 Opened 4 months ago Closed 4 months ago

Scope dialog.css styles to dialog custom element

Categories

(Toolkit :: Themes, task, P1)

task

Tracking

()

RESOLVED FIXED
mozilla76
Tracking Status
firefox76 --- fixed

People

(Reporter: ntim, Assigned: ntim)

References

(Blocks 2 open bugs)

Details

Attachments

(3 files)

+++ This bug was initially created as a clone of Bug #1624865 +++

The dialog.css styles are fairly self-contained and <dialog> is already using shadow DOM, so doing this should be fairly easy.

Summary: Scope dialog styles to dialog custom element → Scope dialog.css styles to dialog custom element
Priority: -- → P1
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/03281cc4980b
Scope dialog.css styles to dialog custom element. r=dao

Bug 1546375 has since been fixed, so removing them was unnecessary.

Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/a8ced22851c2
Re-add default namespaces in dialog.css that didn't need removing.
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/dd34f9158940
Fix broken .spacer selector in dialog.js.
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
Blocks: 1625624

Richard/Magnus, just a quick heads up there are some changes here that TB will probably want to port.

Flags: needinfo?(richard.marti)
Flags: needinfo?(mkmelin+mozilla)

Thanks, Tim. I'm on a patch already.

Flags: needinfo?(richard.marti)
Flags: needinfo?(mkmelin+mozilla)
You need to log in before you can comment on or make changes to this bug.