1624882 - Scope dialog.css styles to dialog custom element

Status: RESOLVED FIXED

(Toolkit :: Themes, task, P1)

Description

[Tim Nguyen :ntim]

+++ This bug was initially created as a clone of Bug #1624865 +++

The dialog.css styles are fairly self-contained and <dialog> is already using shadow DOM, so doing this should be fairly easy.

Comment 1

[Tim Nguyen :ntim]

Attachment: Bug 1624882 - Scope dialog.css styles to dialog custom element.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/03281cc4980b
Scope dialog.css styles to dialog custom element. r=dao

Comment 3

[Tim Nguyen :ntim]

Attachment: Bug 1624882 - Re-add default namespaces in dialog.css that didn't need removing.

Bug 1546375 has since been fixed, so removing them was unnecessary.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a8ced22851c2
Re-add default namespaces in dialog.css that didn't need removing.

Comment 5

[Tim Nguyen :ntim]

Attachment: Bug 1624882 - Fix broken .spacer selector in dialog.js.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dd34f9158940
Fix broken .spacer selector in dialog.js.

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/03281cc4980b
https://hg.mozilla.org/mozilla-central/rev/a8ced22851c2

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/dd34f9158940

Comment 9

[Tim Nguyen :ntim]

Richard/Magnus, just a quick heads up there are some changes here that TB will probably want to port.

Comment 10

[Richard Marti (:Paenglab)]

Thanks, Tim. I'm on a patch already.