1624980 - ./mach bootstrap for artifact builds doesn't install fix-stacks

Status: RESOLVED FIXED

(Firefox Build System :: Bootstrap Configuration, defect)

Description

[Henrik Skupin (:whimboo) [⌚️UTC+2]]

I tried to analyze a DMD output file with dmd.py but when trying to do so I got the failure that the file fix-stacks cannot be found, and that ./mach bootstrap should be run. But that command doesn't install the file if an artifact build has been selected. Only when you switch to a full build it will be installed.

It would be great to also get it installed into ~/.mozbuild/ when an artifact build has been selected.

Andrew mentioned that Nicholas changed the code recently in how it gets installed. So he might be able to help here.

Comment 1

[Nicholas Nethercote [:njn] (On Long Service Leave)]

Thanks for the report. I will try to work out what is necessary here.

Comment 2

[Nicholas Nethercote [:njn] (On Long Service Leave)]

Attachment: Bug 1624980 - Install `fix-stacks` with `mach bootstrap` on artifact builds. r=glandium

Because it's needed for DMD, which can be run on artifact builds.

Comment 3

[Nicholas Nethercote [:njn] (On Long Service Leave)]

I tested this locally:

• I removed my installed fix-stacks.
• I did mach bootstrap for an artifact build, and fix-stacks was not installed.
• I applied the patch and did mach bootstrap again for an artifact build, and fix-stacks was installed this time.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb1f05bf3691
Install `fix-stacks` with `mach bootstrap` on artifact builds. r=glandium

Comment 5

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/bb1f05bf3691