1619837 - Eliminate use of `fix_{linux,macosx}_stack.py` in `utils.py`

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, task)

Description

[Nicholas Nethercote [inactive]]

utils.py uses fix_linux_stack.py and fix_macosx_stack.py. These can now be replaced with fix_stacks.py, for speed and code simplicity improvements.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Bug 1619837 - Make `fix_stacks.py` handle input that doesn't end in a newline. r=erahm

This is needed for utils.py to use fix_stacks.py without getting hangs.

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: Bug 1619837 - Eliminate use of `fix_{linux,macosx}_stack.py` in `utils.py`. r=gsvelto

Because fix_stacks.py is faster and cross-platform.

Depends on D65678

Comment 3

[Nicholas Nethercote [inactive]]

Attachment: Bug 1619837 - [DRAFT] Fix `fix-stacks` toolchain dependencies.

It's currently installed on all platforms that run xpcshell tests, but some
platforms that need fix-stacks don't run xpcshell tests. This commit makes it
a direct dependency for all the platforms that need it.

Comment 4

[Nicholas Nethercote [inactive]]

Attachment: Bug 1619837 - Extend `fix-stacks` dependencies. r=glandium

First, with fix_stacks.py now being used on most test suites, those test
suites need a dependency on fix-stacks.

Second, for those few configurations that don't run xpcshell tests, we need a
fix-stacks dependency in the build job. This is because xpcshell self tests
run during the build job, but the existing xpcshell test dependency doesn't
cover that case.

Comment 5

[Nicholas Nethercote [inactive]]

Attachment: Bug 1619837 - Make `fix_stacks.py` more like `fix_linux_stacks.py`. r=erahm

Specifically:

• handle input that doesn't end in a newline;
• only pass lines that match the regexp to fix-stacks.

These changes are needed for utils.py to use fix_stacks.py without
problems.

Depends on D65943

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/973cf06031df
Extend `fix-stacks` dependencies. r=glandium

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/973cf06031df

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a6baed370a03
Make `fix_stacks.py` more like `fix_linux_stacks.py`. r=erahm

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c6bc4817cea2
Eliminate use of `fix_{linux,macosx}_stack.py` in `utils.py`. r=gsvelto

Comment 10

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/a6baed370a03

Comment 11

[Stefan Hindli [:stefan_hindli]]

Backed out changeset c6bc4817cea2 (Bug 1619837) for causing perma mochitest tier2 failure in testing/mochitest/tests/python/test_basic_mochitest_plain.py CLOSED TREE

https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=linux%2Cx64%2Cdebug%2Cpython%2C2%2Cunit%2Ctests%2Csource-test-python-mochitest-harness-linux64%2Fdebug%2Cpy2%28mch%29&tochange=597d165cd5d3f66bb9b68d9adc7b8f4d6777d3de&fromchange=40006dd7366d284f512415a75d1589654402be1a&selectedJob=292632315

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=292632315&repo=autoland&lineNumber=239

Comment 12

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2aadc604b542
Backed out changeset c6bc4817cea2 for causing perma mochitest tier2 failure in testing/mochitest/tests/python/test_basic_mochitest_plain.py CLOSED TREE

Comment 13

[Nicholas Nethercote [inactive]]

EDIT: Ah, I found the problem: "Exception: cannot find fix-stacks; please run ./mach bootstrap".

I'm still not pleased about getting backed out for failure of a tier2 test job that wasn't even running on try pushes.

Comment 14

[Nicholas Nethercote [inactive]]

Attachment: Bug 1619837 - Add a missing `fix-stacks` dependency for the `py2(mch)` test job. r=erahm

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e5cd778db960
Add a missing `fix-stacks` dependency for the `py2(mch)` test job. r=erahm
https://hg.mozilla.org/integration/autoland/rev/a780a89ed13f
Eliminate use of `fix_{linux,macosx}_stack.py` in `utils.py`. r=gsvelto

Comment 16

[Nicholas Nethercote [inactive]]

Attachment: Bug 1619837 - Add a missing `fix-stacks` dependency for the `py2(ref)` test job. r=erahm

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ffd615bf92dd
Add a missing `fix-stacks` dependency for the `py2(ref)` test job. r=erahm

Comment 18

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/e5cd778db960
https://hg.mozilla.org/mozilla-central/rev/a780a89ed13f
https://hg.mozilla.org/mozilla-central/rev/ffd615bf92dd