Eliminate use of `fix_{linux,macosx}_stack.py` in `utils.py`
Categories
(Toolkit :: Crash Reporting, task)
Tracking
()
Tracking | Status | |
---|---|---|
firefox76 | --- | fixed |
People
(Reporter: n.nethercote, Assigned: n.nethercote)
References
Details
Attachments
(5 files, 2 obsolete files)
utils.py
uses fix_linux_stack.py
and fix_macosx_stack.py
. These can now be replaced with fix_stacks.py
, for speed and code simplicity improvements.
![]() |
Assignee | |
Comment 1•5 years ago
|
||
This is needed for utils.py
to use fix_stacks.py
without getting hangs.
![]() |
Assignee | |
Comment 2•5 years ago
|
||
Because fix_stacks.py
is faster and cross-platform.
Depends on D65678
Updated•5 years ago
|
![]() |
Assignee | |
Comment 3•5 years ago
|
||
It's currently installed on all platforms that run xpcshell tests, but some
platforms that need fix-stacks
don't run xpcshell tests. This commit makes it
a direct dependency for all the platforms that need it.
![]() |
Assignee | |
Comment 4•5 years ago
|
||
First, with fix_stacks.py
now being used on most test suites, those test
suites need a dependency on fix-stacks
.
Second, for those few configurations that don't run xpcshell tests, we need a
fix-stacks
dependency in the build job. This is because xpcshell self tests
run during the build job, but the existing xpcshell test dependency doesn't
cover that case.
![]() |
Assignee | |
Comment 5•5 years ago
|
||
Specifically:
- handle input that doesn't end in a newline;
- only pass lines that match the regexp to
fix-stacks
.
These changes are needed for utils.py
to use fix_stacks.py
without
problems.
Depends on D65943
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Pushed by nnethercote@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/973cf06031df Extend `fix-stacks` dependencies. r=glandium
Comment 7•5 years ago
|
||
bugherder |
![]() |
Assignee | |
Updated•5 years ago
|
![]() |
Assignee | |
Updated•5 years ago
|
Updated•5 years ago
|
Pushed by nnethercote@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a6baed370a03 Make `fix_stacks.py` more like `fix_linux_stacks.py`. r=erahm
![]() |
Assignee | |
Updated•5 years ago
|
Pushed by nnethercote@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c6bc4817cea2 Eliminate use of `fix_{linux,macosx}_stack.py` in `utils.py`. r=gsvelto
Comment 10•5 years ago
|
||
bugherder |
Comment 11•5 years ago
|
||
Backed out changeset c6bc4817cea2 (Bug 1619837) for causing perma mochitest tier2 failure in testing/mochitest/tests/python/test_basic_mochitest_plain.py CLOSED TREE
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=292632315&repo=autoland&lineNumber=239
Updated•5 years ago
|
Comment 12•5 years ago
|
||
Backout by shindli@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2aadc604b542 Backed out changeset c6bc4817cea2 for causing perma mochitest tier2 failure in testing/mochitest/tests/python/test_basic_mochitest_plain.py CLOSED TREE
![]() |
Assignee | |
Comment 13•5 years ago
•
|
||
EDIT: Ah, I found the problem: "Exception: cannot find fix-stacks
; please run ./mach bootstrap
".
I'm still not pleased about getting backed out for failure of a tier2 test job that wasn't even running on try pushes.
![]() |
Assignee | |
Updated•5 years ago
|
![]() |
Assignee | |
Comment 14•5 years ago
|
||
Comment 15•5 years ago
|
||
Pushed by nnethercote@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e5cd778db960 Add a missing `fix-stacks` dependency for the `py2(mch)` test job. r=erahm https://hg.mozilla.org/integration/autoland/rev/a780a89ed13f Eliminate use of `fix_{linux,macosx}_stack.py` in `utils.py`. r=gsvelto
![]() |
Assignee | |
Comment 16•5 years ago
|
||
Comment 17•5 years ago
|
||
Pushed by nnethercote@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ffd615bf92dd Add a missing `fix-stacks` dependency for the `py2(ref)` test job. r=erahm
Comment 18•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e5cd778db960
https://hg.mozilla.org/mozilla-central/rev/a780a89ed13f
https://hg.mozilla.org/mozilla-central/rev/ffd615bf92dd
Description
•