Closed Bug 1625182 Opened 10 months ago Closed 10 months ago

[wpt-sync] Sync PR 22472 - [wakelock] Rename feature policy

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox76 fixed)

RESOLVED FIXED
mozilla76
Tracking Status
firefox76 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 22472 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/22472
Details from upstream follow.

Wanming Lin <wanming.lin@intel.com> wrote:

[wakelock] Rename feature policy

This CL renames "wake-lock" to "screen-wake-lock" in policy-controlled feature
specific for screen wake lock, and leaves system wake lock's policy control
as allowed by default because its associated feature policy is not defined yet.

Spec changes at: https://github.com/w3c/wake-lock/pull/255

Bug: 1064685
Change-Id: I7701a532a7688d708a75aedafc8713d671da6e2b

Reviewed-on: https://chromium-review.googlesource.com/2119886
WPT-Export-Revision: 289647f77524f1a4c5dee62742b9071bdac74ec0

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 53 tests

Status Summary

Firefox

OK : 6
PASS: 4[GitHub] 51[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt]
FAIL: 10

Chrome

OK : 6
PASS: 6
FAIL: 8

Safari

OK : 6
PASS: 4
FAIL: 10

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/wake-lock/wakelock-enabled-by-feature-policy.https.sub.html
Feature-Policy header {"screen-wake-lock" : [""]} allows cross-origin iframes.: FAIL (Chrome: FAIL, Safari: FAIL)
Feature-Policy header {"screen-wake-lock" : ["
"]} allows same-origin iframes.: FAIL (Chrome: FAIL, Safari: FAIL)
Feature-Policy header {"screen-wake-lock" : ["*"]} allows the top-level document.: FAIL (Chrome: PASS, Safari: FAIL)
/wake-lock/wakelock-enabled-by-feature-policy-attribute-redirect-on-load.https.sub.html
Feature-Policy allow="screen-wake-lock" allows same-origin relocation: FAIL (Chrome: FAIL, Safari: FAIL)
/wake-lock/wakelock-disabled-by-feature-policy.https.sub.html
Feature-Policy header {"screen-wake-lock" : []} disallows the top-level document.: FAIL (Chrome: FAIL, Safari: FAIL)
/wake-lock/wakelock-enabled-by-feature-policy-attribute.https.sub.html
Feature policy "screen-wake-lock" can be enabled in same-origin iframe using allow="screen-wake-lock" attribute: FAIL (Chrome: FAIL, Safari: FAIL)
Feature policy "screen-wake-lock" can be enabled in cross-origin iframe using allow="screen-wake-lock" attribute: FAIL (Chrome: FAIL, Safari: FAIL)
/wake-lock/wakelock-supported-by-feature-policy.html
document.featurePolicy.features should advertise screen-wake-lock.: FAIL (Chrome: FAIL, Safari: FAIL)
/wake-lock/wakelock-enabled-on-self-origin-by-feature-policy.https.sub.html
Feature-Policy header screen-wake-lock "self" allows same-origin iframes.: FAIL (Chrome: FAIL, Safari: FAIL)
Feature-Policy header screen-wake-lock "self" allows the top-level document.: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/29ef17e194d1
[wpt PR 22472] - [wakelock] Rename feature policy, a=testonly
https://hg.mozilla.org/integration/autoland/rev/a08a9099aece
[wpt PR 22472] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
You need to log in before you can comment on or make changes to this bug.