1625299 - Reinstate print-progress dialog (can't print with print progress dialog)

Status: RESOLVED FIXED

(MailNews Core :: Printing, defect, P1)

Description

[Ben Campbell]

I disabled the print-progress dialog in Bug 1620314 as it was preventing the printing from working.
It'd be nice to fix it.
There's a bit of analysis in Bug 1620314.

Comment 1

[Firefox Bug Husbandry Bot]

Because this bug's Severity has not been changed from the default since it was filed, and it's Priority is -- (Backlog,) indicating it has has not been previously triaged, the bug's Severity is being updated to -- (default, untriaged.)

Comment 2

[Firefox Bug Husbandry Bot]

Because this bug's Severity has not been changed from the default since it was filed, and it's Priority is -- (Backlog,) indicating it has has not been previously triaged, the bug's Severity is being updated to -- (default, untriaged.)

Comment 3

[Firefox Bug Husbandry Bot]

Because this bug's Severity has not been changed from the default since it was filed, and it's Priority is -- (Backlog,) indicating it has has not been previously triaged, the bug's Severity is being updated to -- (default, untriaged.)

Comment 4

[Firefox Bug Husbandry Bot]

The severity of these bugs was changed, mistakenly, from normal to S3.

Because these bugs have a priority of --, indicating that they have not been previously triaged, these bugs should be changed to Severity of --.

Comment 6

[Magnus Melin [:mkmelin]]

The cause is bug 1630095.

Comment 7

[Wayne Mery (:wsmwk)]

I'm concerned about bug 1630095 impact on our ability to get a fully representative cross section of testers for version 78.

Is disabling the print progress really a solid workaround? For testing publicity we'll need to post something in release / testing notes of users should expect.

Comment 8

[WaltS48 [:walts48]]

Print progress dialog is reinstated in 77.0b2 and 77.0b3. This is my default setting "print.show_print_progress;true"

Prevents printing emails from 'Print Preview", using just "Print" works. Calendar printing works from its "Print Preview".

Printing emails from "Print Preview" works with the pref set to "false".

Comment 9

[Magnus Melin [:mkmelin]]

Attachment: bug1625299_reinstate_print.patch

It's working again.

Comment 10

[Ben Campbell]

Comment on attachment 9155626 [details] [diff] [review]
bug1625299_reinstate_print.patch

Review of attachment 9155626 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good (And seeing bug 1639816 is quite the relief!).

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6ce278c40c58
Reinstate print-progress dialog (can't print with print progress dialog). r=benc

Comment 12

[Magnus Melin [:mkmelin]]

Comment on attachment 9155626 [details] [diff] [review]
bug1625299_reinstate_print.patch

Want the print progress dialog back. Bug 1639816 is on m-c beta so we can just uplift this too.

Comment 13

[Wayne Mery (:wsmwk)]

Comment on attachment 9155626 [details] [diff] [review]
bug1625299_reinstate_print.patch

Approved for beta

Comment 14

[Geoff Lankow (:darktrojan)]

Thunderbird 78.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/1addcfca7d57