Closed Bug 1639816 Opened 2 months ago Closed 1 month ago

Printing local pages via Print Menu fails with In Printing:Print:Done handler, got unexpected rv 2147746065

Categories

(Core :: Printing: Setup, defect, P1)

defect

Tracking

()

VERIFIED FIXED
mozilla79
Tracking Status
firefox-esr68 --- unaffected
firefox76 --- wontfix
firefox77 --- wontfix
firefox78 --- verified
firefox79 --- verified

People

(Reporter: emilghitta, Assigned: jwatt)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression, Whiteboard: [print2020_v78][layout:backlog])

Attachments

(2 files)

Attached image printProblem .gif

Affected versions

  • Firefox 76.0.1 (BuildId:20200507114007)
  • Firefox 77.0b8 (BuildId:20200519220135)
  • Firefox 78.0a1 (BuildId:20200520213050)

Unaffected versions

  • Firefox 68.8.0esr (BuildId:20200429190206)

Affected platforms

  • Windows 10 64bit
  • Ubuntu 18.04 64bit

Unaffected platforms

  • macOS 10.14

Steps to reproduce

  1. Launch Firefox.
  2. Access the about:support page.
  3. Press CTRL + P in order to open the Print Menu.
  4. Click on Print.
  5. Redo Steps 3 & 4.

Expected result

  • The about:support page is successfully printed.

Actual result

  • Step 3: Nothing happens (for both print to file/pdf or starting an actual print job).
  • Step 5: The following error is shown: Some printing functionality is not currently available.

Regression Range
This seems to be a regression

Notes

  • macOS has a different behavior See Bug 1639823
  • Printing the page via print preview seems to work as expected.
  • After triggering this issue navigation from about:support to any other local page (about:cache,etc) seems to no longer work. A workaround for this is opening another tab and accessing the local page or from within the same broken tab accessing a remote website and then a local page.
  • The Browser Console outputs the following error: In Printing:Print:Done handler, got unexpected rv 2147746065. 2 PrintingChild.jsm:403
  • At first try it will not print and the error is displayed, at second try (in a new tab or after accessing a remote page and going back) it will print but printing again after a successful print seems to no longer work again.

Hi Jonathan,

It seems that mozregression pointed out Bug 1552966 for causing this issue.

Can you please take a look?

Thank you!

Flags: needinfo?(jwatt)
Severity: S2 → S3
Has Regression Range: --- → yes
Has STR: --- → yes
Component: Printing → Printing: Setup
Product: Toolkit → Core

Pretty sure we're not going to be able to fix this for 78 at this point. Given how infrequently people are likely to print local pages, we may have to live with it for a release and aim for 79.

Priority: -- → P2
Whiteboard: [print2020][layout:backlog]

As pointed out to me offline, v78 is an ESR release and we should try to avoid shipping this regression in an ESR release.

I've had some trouble figuring out a proper solution for this. However, it is just one small part of the regressing patch that causes the problem and there have been no subsequent patches that have built on those changes. Being pragmatic, we should back out the nsPrintProgress.cpp changes.

Assignee: nobody → jwatt
Flags: needinfo?(jwatt)
Priority: P2 → P1
Whiteboard: [print2020][layout:backlog] → [print2020_v78][layout:backlog]
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/autoland/rev/cb065e51467d
Fix printing of built-in pages (partial backout of bug 1552966). r=farre

Comment on attachment 9154379 [details]
Bug 1639816. Fix printing of built-in pages (partial backout of bug 1552966). r=farre

Beta/Release Uplift Approval Request

  • User impact if declined: Users are unable to print built-in pages like about:support etc.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): It backs out the problematic change, reverting us back to the previous, working, behavior.
  • String changes made/needed: none
Attachment #9154379 - Flags: approval-mozilla-beta?
Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla79

Walt, does this fix Thunderbird printing on daily?

Flags: needinfo?(wls220spring)

Windows 10 TB 79.0a1
Opened the Troubleshooting Information page and printing to a PDF file and paper copy worked.
Selected an email and used File > Print Preview and printing a paper copy worked.

Printing also works as tested on Windows 10 on Ubuntu 18.04.4 LTS TB 79.0a1.

Name Thunderbird
Version 79.0a1
Build ID 20200607105821

Flags: needinfo?(wls220spring)

Comment on attachment 9154379 [details]
Bug 1639816. Fix printing of built-in pages (partial backout of bug 1552966). r=farre

approved for 78.0b5

Attachment #9154379 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

This issue is verified fixed using Firefox 79.0a1 (BuildId:20200609151649) and Firefox 78.0b5 (BuildId:20200609215727) on Windows 10 64bit and Ubuntu 18.04 64bit.

Status: RESOLVED → VERIFIED

Added a regression TC in our printing test suite for this issue & for Bug 1639823 in order to expand our test coverage for our recurring tests.

Flags: in-qa-testsuite+
Blocks: 1557682
You need to log in before you can comment on or make changes to this bug.