1625300 - The identity field in the message compose window has dark text when the System dark setting is enabled in macos

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Alessandro Castellani [:aleca]]

Attachment: Screen Shot 2020-03-26 at 2.06.03 PM.png

The issue presents itself only if the System dark theme is enabled, but the Thunderbird theme is set to Default.

Comment 1

[Alessandro Castellani [:aleca]]

Attachment: 1625300-msgidentity-dark.diff

Comment 2

[Richard Marti (:Paenglab)]

Comment on attachment 9136131 [details] [diff] [review]
1625300-msgidentity-dark.diff

I think it would be better when you give msgIdentity on Mac a `color: inherit;` to always get the colour the toolbar has. Linux and Windows have this already through the custom menulist stylings.

Comment 3

[Alessandro Castellani [:aleca]]

Attachment: 1625300-msgidentity-dark.diff

Good point, and added that style on the dedicated osx file.

Comment 4

[Richard Marti (:Paenglab)]

Comment on attachment 9136162 [details] [diff] [review]
1625300-msgidentity-dark.diff

Thanks, this works. But I thought, you put the inheriting to https://searchfox.org/comm-central/rev/2167e182bc99d2d08556842371cb75e286f4a92e/mail/themes/osx/mail/compose/messengercompose.css#105. Here it gets the toolbar colour every time. Then we haven't to change it again, when we decide LW-themes can theme this area too for example or the user changes the text colour in this toolbar.

r+ with this considered.

Comment 5

[Alessandro Castellani [:aleca]]

Attachment: 1625300-msgidentity-dark.diff

Indeed, that's better, thanks.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d2c1668f2edf
MACOS: Fix msgIdentity font color with System dark theme enabled. r=paenglab