1625309 - Attempt to remove the frame script and only use WebChannels for profile injection and symbolication

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), enhancement, P3)

Description

[Greg Tatum [:gregtatum]]

We now have a WebChannel available for profiler.firefox.com, we should try and use it for symbolication and for profile injection. This would be more secure, and more maintainable. The question is the speed difference between the two.

Comment 1

[Markus Stange [:mstange]]

This requires work both in the Firefox profiler front-end code, and in the devtools code.

For profile injection, we need to make sure to supply the right profile to the right tab. The user might have captured several profiles in various open tabs. If the user reloads one of these tabs, the WebChannel will re-request the profile.
The WebChannel request supplies the requesting browser instance. We could have a WeakMap that maps the browser from the opened tab to the profile captured for that tab. We'll just need to have a place to store that state; at the moment, handleWebChannelMessage is a free function but maybe we'll want to wrap it in some kind of stateful object. And then every time we capture a profile, we register it with that stateful object.

Comment 2

[Markus Stange [:mstange]]

Attachment: Bug 1625309 - Remove the frame script and instead use the WebChannel to expose the profile and symbolication. r=julienw

Depends on D121932

Comment 3

[Markus Stange [:mstange]]

The corresponding front-end change is in https://github.com/firefox-devtools/profiler/pull/3482 and will need to land first.

Comment 4

[Markus Stange [:mstange]]

Attachment: Bug 1625309 - Use /from-browser. r=julienw

This was implemented in https://github.com/firefox-devtools/profiler/pull/3466.

Depends on D121933

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:mstange, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 6

[Markus Stange [:mstange]]

I was planning to write a test, to check that reloading an opened profiler tab always has the correct profile. But realistically I am not going to get to that soon. So I think I'll just land this as-is.

The other change that I thought about making was to add some kind of workaround for users who have an old version of the profiler cached in the service worker. But at this point it's been almost 3 months since the front-end added support for the web channel, so I think this concern is alleviated.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/801a44944072
Remove the frame script and instead use the WebChannel to expose the profile and symbolication. r=julienw
https://hg.mozilla.org/integration/autoland/rev/9ad8265a7c22
Use /from-browser. r=julienw

Comment 8

[Marian-Vasile Laza]

Backed out 3 changesets (Bug 1726281, Bug 1625309) for causing mochitest failures on browser_popup-profiler-states.js.
Backout link
Push with failures
Failure Log
dt2 log

Comment 9

[Markus Stange [:mstange]]

Hmm, seems like I had never pushed this to try...

The failing test makes use of fake-frontend.html which needs to be changed to use the WebChannel instead of the frame script.

Comment 10

[Markus Stange [:mstange]]

Attachment: Bug 1625309 - Make fake-frontend.html work with the WebChannel. r=julienw

Depends on D121933

Comment 11

[Markus Stange [:mstange]]

https://treeherder.mozilla.org/jobs?repo=try&revision=db69ae295ab466b82110b1ef70cdeb2c46eac275

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/10bdd3f45b4d
Remove the frame script and instead use the WebChannel to expose the profile and symbolication. r=julienw
https://hg.mozilla.org/integration/autoland/rev/2d78cef7380f
Make fake-frontend.html work with the WebChannel. r=julienw
https://hg.mozilla.org/integration/autoland/rev/b52cd8a49ebd
Use /from-browser. r=julienw

Comment 13

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/10bdd3f45b4d
https://hg.mozilla.org/mozilla-central/rev/2d78cef7380f
https://hg.mozilla.org/mozilla-central/rev/b52cd8a49ebd