1625480 - Convert remaining notifications strings from browser.dtd to fluent

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, task, P3)

Description

[:Gijs (he/him)]

These strings: https://searchfox.org/mozilla-central/rev/b712398b7fae54ef377a558d6f16dede7a7f8530/browser/locales/en-US/chrome/browser/browser.dtd#384-400

Are used from panelUI.inc.xhtml . They should go into https://searchfox.org/mozilla-central/source/browser/locales/en-US/browser/appMenuNotifications.ftl . The ftl file is already dynamically appended to the document in https://searchfox.org/mozilla-central/source/browser/components/customizableui/content/panelUI.js#863 which I think should be sufficient.

You can get these 3 notifications to come up by running these tests with ./mach test:

https://searchfox.org/mozilla-central/source/browser/components/extensions/test/browser/browser_ext_chrome_settings_overrides_home.js#438

https://searchfox.org/mozilla-central/source/browser/components/extensions/test/browser/browser_ext_url_overrides_newtab.js#108

https://searchfox.org/mozilla-central/source/browser/components/extensions/test/browser/browser_ext_tabs_hide.js#114

To pause the test and keep the notification visible, you probably want to add a new line after each of the highlighted lines linked above with something like:

await new Promise(r => setTimeout(r, 20 * 1000));

which waits 20 seconds.

Comment 1

[:Gijs (he/him)]

(In reply to :Gijs (he/him) from comment #0)

The ftl file is already dynamically appended to the document in https://searchfox.org/mozilla-central/source/browser/components/customizableui/content/panelUI.js#863 which I think should be sufficient.

Actually, I think this might be wrong - check what happens, but if strings aren't showing up, copy the insertFTLIfNeeded() line into the open method in https://searchfox.org/mozilla-central/source/browser/components/extensions/ExtensionControlledPopup.jsm#212 .

Comment 2

[Artem]

Attachment: Bug 1625480 - convert remaining notifications strings from browser.dtd to fluent r?gijs

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/32c22fdaf8c8
convert remaining notifications strings from browser.dtd to fluent r=Gijs,fluent-reviewers,flod

Comment 4

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/32c22fdaf8c8

Comment 5

[Anca Soncutean, Desktop QA]

Verified fixed as part of PI 551; tested with Nightly 77 across platforms (Windows 10, macOS 10.15 and Ubuntu 18.04).