1625522 - ./mach jit-test --run-binast fails with `TypeError: startswith first arg must be bytes or a tuple of bytes, not str`

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P2)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

Trying to run BinAST tests with a mach build gets me

~/unified$ ./mach jit-test --run-binast
Traceback (most recent call last):
  File "/home/matthew/unified/js/src/jit-test/jit_test.py", line 403, in <module>
    main(sys.argv[1:])
  File "/home/matthew/unified/js/src/jit-test/jit_test.py", line 233, in main
    if not is_binast_enabled.startswith('true'):

Comment 1

[Matthew Gaudet (he/him) [:mgaudet]]

./js/src/jit-test/jit_test.py --run-binast ./obj-opt-x86_64-pc-linux-gnu/dist/bin/js does work however

Comment 2

[Steve Fink [:sfink] [:s:]]

(In reply to Matthew Gaudet (he/him) [:mgaudet] from comment #1)

./js/src/jit-test/jit_test.py --run-binast ./obj-opt-x86_64-pc-linux-gnu/dist/bin/js does work however

Yeah, that's because it uses your system python, which must be Python 2 for you. On my Fedora 31, it's now Python 3. And I foolishly made ./mach jit-test force Python 3 because it made me feel good before it made me feel bad (from the regressions).

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a defect, but please change it back in case of error.

Comment 4

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1625522 - py3 compatibility with jit-test --run-binast

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6e5d9f93f320
py3 compatibility with jit-test --run-binast r=arai

Comment 6

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/6e5d9f93f320

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Doesn't seem like this is a common enough scenario to worry about uplifting to 75, but LMK if you feel strongly otherwise.