1619475 - Partial conversion of js/src test suites to Python 3

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P3)

Description

[Steve Fink [:sfink] [:s:]]

I recently upgraded to Fedora 31, which ships a Python 3 in /usr/bin/python. Which means that I error out whenever I run the shell tests.

We seem to have a cluster of partially-completed bugs that convert parts of things. I didn't see (or remember) those before I dove in and fixed things up enough so I could run the subsets of jstests and jit-tests that I normally use.

I figure it's worth landing my fixes and cleaning up the rest eventually.

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1619475 - partial Python 3 compatibility for jit-tests and jstests

This fixes all of the jit-test problems I encountered, and fixes all but the wpt portion of jstests. This is unnecessary, but it also ports jstests from optparse to argparse (because optparse is deprecated, because I like argparse better, and because it happened to fix the minor compatibility issue I ran into even though it has a trivial fix on its own.)

Comment 2

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1619475 - also convert jstests from optparse to argparse

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/057d1d3a9ed1
partial Python 3 compatibility for jit-tests and jstests r=arai
https://hg.mozilla.org/integration/autoland/rev/efb82594b292
also convert jstests from optparse to argparse r=arai

Comment 4

[Cristian Brindusan [:cbrindusan]]

Backed out 2 changesets (Bug 1619475) for linux build bustages.
https://hg.mozilla.org/integration/autoland/rev/89826f85b5bd69574f7e268b67c24487d70d1d95

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=efb82594b292ffc7e1da93bfa863f0eef5278fa5&selectedJob=291719096

Failure log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=291719096&repo=autoland&lineNumber=6730

Comment 5

[Phabricator Automation]

Comment on attachment 9130891 [details]
Bug 1619475 - also convert jstests from optparse to argparse

Revision D65400 was moved to bug 1609208. Setting attachment 9130891 [details] to obsolete.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c753faaef709
partial Python 3 compatibility for jit-tests and jstests r=arai
https://hg.mozilla.org/integration/autoland/rev/eb037e72681e
also convert jstests from optparse to argparse r=arai

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/c753faaef709
https://hg.mozilla.org/mozilla-central/rev/eb037e72681e