1625806 - Decision task bustage on try-comm-central, references to expired job

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Rob Lemley [:rjl]]

The decision task on try-comm-central errors out:

'task.dependencies' references tasks that expires before 'task.deadline' this is not allowed, see tasks:
 * OIKXEGQ8SX2rS5mcmh5pYg,
All taskIds in 'task.dependencies' **must** have
'task.expires' greater than the 'deadline' for this task.

The offending task is a libotr build. On try, they expire after 28 days so you can no longer use them as a dependency.
For regular toolchain jobs the expiration is 12 months (even on try).

Comment 1

[Rob Lemley [:rjl]]

Attachment: Expire all libotr build tasks after 1 year

Not sure why I set try jobs to 28 days in the first place.
Toolchain jobs on try expire after a year, so that's probably
a good place to start.

A better fix will be to somehow check the expiration of the task
in question.

Comment 2

[Rob Lemley [:rjl]]

Attachment: Removed unused variable from build-libotr.sh

Force a rebuild of libotr to deal with the expired task.

Comment 3

[Rob Lemley [:rjl]]

Marking leave-open because even with the above "fix" if we don't update libotr code within a year we will have the same issue on all repos, not just try-comm-central.
Chances are the code will get touch sometime in that year, but it may not.
The other thing is I have been meaning audit the index lookup on the libotr build jobs to make sure it really works as intended. When something else causes a libotr rebuild, such as a toolchain dependency changing, does the index point to the new build like it should?

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b90745e722fc
Expire all libotr build tasks after 1 year. r=darktrojan
https://hg.mozilla.org/comm-central/rev/529118ef44ee
Removed unused variable from build-libotr.sh. r=darktrojan

Comment 5

[Rob Lemley [:rjl]]

Getting this out of my active queue for now.

Comment 6

[Rob Lemley [:rjl]]

This is back causing trouble on try-comm-central. Will push a hot-fix as soon as I test it and will come up with better longterm fix ASAP.

Comment 7

[Firefox Bug Husbandry Bot]

Because this bug's Severity has not been changed from the default since it was filed, and it's Priority is -- (Backlog,) indicating it has has not been previously triaged, the bug's Severity is being updated to -- (default, untriaged.)

Comment 8

[Firefox Bug Husbandry Bot]

Because this bug's Severity has not been changed from the default since it was filed, and it's Priority is -- (Backlog,) indicating it has has not been previously triaged, the bug's Severity is being updated to -- (default, untriaged.)

Comment 9

[Firefox Bug Husbandry Bot]

Because this bug's Severity has not been changed from the default since it was filed, and it's Priority is -- (Backlog,) indicating it has has not been previously triaged, the bug's Severity is being updated to -- (default, untriaged.)

Comment 10

[Firefox Bug Husbandry Bot]

The severity of these bugs was changed, mistakenly, from normal to S3.

Because these bugs have a priority of --, indicating that they have not been previously triaged, these bugs should be changed to Severity of --.

Comment 11

[Rob Lemley [:rjl]]

Attachment: Bug 1625806 - Modify build-libotr.sh to work as a toolchain build script. r=darktrojan

Toolchain builds have things in a slightly different arrangement. GECKO_PATH
is at /builds/worker/workspace/build/src, so removing build at line 17 will
delete the checkout we need for the libotr sources.
At the same time, this script will also run on the thunderbird-mingw docker
image which uses the build image layout, and the build directory will need
to be created.
In either case, workspace can be cached between Taskcluster runs under some
circumstances so clearing out the directories that this script uses is still
warranted.

Comment 12

[Rob Lemley [:rjl]]

Attachment: Bug 1625806 - Build libotr as a toolchain dependency. r=darktrojan

The thirdparty build kind has problems with indexing that never really worked
out. By using the existing toolchain kind we can rely on that indexing that has
seen a lot more use and be more confident that it works right.

Depends on D78205

Comment 13

[Rob Lemley [:rjl]]

Attachment: Bug 1625806 - Use libotr toolchain task instead of thirdparty task as build dependency. r=darktrojan

Depends on D78206

Comment 14

[Rob Lemley [:rjl]]

Attachment: Bug 1625806 - Remove unused thirdparty transform code. r?darktrojan

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0dee0f41284b
Modify build-libotr.sh to work as a toolchain build script. r=darktrojan
https://hg.mozilla.org/comm-central/rev/84e760152741
Build libotr as a toolchain dependency. r=darktrojan
https://hg.mozilla.org/comm-central/rev/8ef9d3a2c1ec
Use libotr toolchain task instead of thirdparty task as build dependency. r=darktrojan
https://hg.mozilla.org/comm-central/rev/98c0fbe4a5e8
Remove unused thirdparty transform code. r=darktrojan

Comment 16

[Rob Lemley [:rjl]]

Comment on attachment 9154049 [details]
Bug 1625806 - Modify build-libotr.sh to work as a toolchain build script. r=darktrojan

[Triage Comment]
Build infra refactoring. This bug goes with bug 1639949 which is required for bug 1634209.

Comment 17

[Rob Lemley [:rjl]]

Thunderbird 78.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/6bf06da9c1b4
https://hg.mozilla.org/releases/comm-beta/rev/95d5fbf2c50e
https://hg.mozilla.org/releases/comm-beta/rev/695db41fd3cd
https://hg.mozilla.org/releases/comm-beta/rev/36684a2e68fc