Closed
Bug 1625855
Opened 4 years ago
Closed 4 years ago
Replace MOZ_MUST_USE with [[nodiscard]] in layout
Categories
(Core :: Layout, task, P3)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla77
| Tracking | Status | |
|---|---|---|
| firefox77 | --- | fixed |
People
(Reporter: cpeterson, Assigned: cpeterson)
References
Details
Attachments
(2 files)
The MOZ_MUST_USE macro is defined as clang's and gcc's nonstandard attribute((warn_unused_result)). Now that we compile as C++17 by default (bug 1560664), we can replace MOZ_MUST_USE with C++17's standard [[nodiscard]] attribute.
|
Assignee | |
Comment 1•4 years ago
|
||
|
||
Updated•4 years ago
|
Attachment #9136675 -
Attachment description: Bug 1625855 - Replace MOZ_MUST_USE with [[nodiscard]] in layout. r?dbaron → Bug 1625855 - Replace MOZ_MUST_USE with [[nodiscard]] in layout. r=TYLin
|
|
Assignee | |
Comment 2•4 years ago
|
||
Are there any Rust crates outside mozilla-central that include or emit Mozilla C++ code that should be updated to use [[nodiscard]] instead of MOZ_MUST_USE?
Depends on D68751
Pushed by cpeterson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fb761a9593ef Replace MOZ_MUST_USE with [[nodiscard]] in layout. r=TYLin https://hg.mozilla.org/integration/autoland/rev/4b3f33567d94 Replace MOZ_MUST_USE with [[nodiscard]] in some Servo Rust code. r=emilio
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/fb761a9593ef
https://hg.mozilla.org/mozilla-central/rev/4b3f33567d94
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox77:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in
before you can comment on or make changes to this bug.
Description
•