RLBox - Port libOgg usage code in the OGGDemuxer to use the RLBox API
Categories
(Core :: Audio/Video: Playback, enhancement, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox77 | --- | fixed |
People
(Reporter: shravanrn, Assigned: shravanrn)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
Move to RLBox API to invoke functions in libOgg in the OGGDemuxer so we can easily switch between unsandboxed and sandboxed versions of libGraphite. For now this task will still use the unsandboxed libOgg included in tree.
|
Assignee | |
Comment 1•4 years ago
|
||
|
||
Updated•4 years ago
|
Pushed by padenot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a3117fce845d Port libOgg usage code in the OGGDemuxer to use the RLBox API r=padenot
|
||
Comment 3•4 years ago
|
||
Backed out 2 changesets (Bug 1626174, Bug 1625876) for build bustages at LibrarySandboxPreload.cpp and OggDemuxer.cpp.
https://hg.mozilla.org/integration/autoland/rev/c5b0c8ec5af32c87e0289d6f85b916ff38ea3727
Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=298654142&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=40fea0f3ab6ceee1e5651a5182d9d9b8594b64c4
and
https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=298654103&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=40fea0f3ab6ceee1e5651a5182d9d9b8594b64c4
Failure log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=298654142&repo=autoland&lineNumber=67696
and
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=298654103&repo=autoland&lineNumber=16319
|
|
Assignee | |
Comment 4•4 years ago
|
||
Ok, it looks like there are two issues
On android there is a warning which triggers Werr based on my change (easy enough to fix)
On linux and other builds, it looks like I inadvertantly removed an include. Not sure why this passed try the first time.
I have updated both phabs.
Pushed by padenot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7382f19a6ade Port libOgg usage code in the OGGDemuxer to use the RLBox API r=padenot
|
||
Comment 6•4 years ago
|
||
| bugherder | ||
|
||
Updated•4 years ago
|
Description
•