Enable use of wasm sandboxed libOgg in the OggDemuxer in linux, mac, try servers
Categories
(Core :: Audio/Video: Playback, enhancement, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox77 | --- | fixed |
People
(Reporter: shravanrn, Assigned: shravanrn)
References
Details
Attachments
(1 file)
Once all use of libOgg in the OggDemuxer has been ported to the RLBox API (Bug 1625876), we need the following steps to enable use of a wasm sandboxing libOgg
- Expose a mozconfig setting that allows wasm sandboxed libOgg to be selectively enabled on builds.
- Modify moz.build configs and to build a wasm sandboxed libOgg in tree.
- Configure binary paths in code so we can load wasm sandboxed libOgg when needed.
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 1•4 years ago
|
||
Pushed by padenot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/40fea0f3ab6c Enable use of wasm sandboxed libOgg in the OggDemuxer in linux, mac, try servers r=padenot,erahm,dmajor,firefox-build-system-reviewers
|
||
Comment 3•4 years ago
|
||
Backed out 2 changesets (Bug 1626174, Bug 1625876) for build bustages at LibrarySandboxPreload.cpp and OggDemuxer.cpp.
https://hg.mozilla.org/integration/autoland/rev/c5b0c8ec5af32c87e0289d6f85b916ff38ea3727
Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=298654142&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=40fea0f3ab6ceee1e5651a5182d9d9b8594b64c4
and
https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=298654103&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=40fea0f3ab6ceee1e5651a5182d9d9b8594b64c4
Failure log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=298654142&repo=autoland&lineNumber=67696
and
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=298654103&repo=autoland&lineNumber=16319
|
|
Assignee | |
Comment 4•4 years ago
|
||
Ok, it looks like there are two issues
On android there is a warning which triggers Werr based on my change (easy enough to fix)
On linux and other builds, it looks like I inadvertantly removed an include. Not sure why this passed try the first time.
I have updated both phabs.
Pushed by padenot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fe830aa941b0 Enable use of wasm sandboxed libOgg in the OggDemuxer in linux, mac, try servers r=padenot,erahm,dmajor,firefox-build-system-reviewers
|
||
Comment 6•4 years ago
|
||
| bugherder | ||
Description
•