Closed Bug 1626052 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 22546 - [LayoutNG] Fixes OOF min/max sizes for nodes w/ %-dependent children.

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla76
Tracking Flags:
Tracking Status
firefox76 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 22546 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/22546
Details from upstream follow.

Ian Kilpatrick <ikilpatrick@chromium.org> wrote:

[LayoutNG] Fixes OOF min/max sizes for nodes w/ %-dependent children.

Previously we just passed in the containing block size, however this was
incorrect for the following case:
\<div style="position: relative; height: 200px;">
\<div style="position: absolute; top: 0; bottom: 100px;">
\<canvas width=1 height=1 style="height: 100%;">\</canvas>
\</div>
\</div>

This pre-calculates the block-size of the OOF-positioned element, and
pass it into the NGBlockNode::MinMaxSizes pass.

Change-Id: I897dc6f9c157bfa1ae63f9821cdb6ed03a218322

Reviewed-on: https://chromium-review.googlesource.com/2122854
WPT-Export-Revision: d2970d78aeb5e08e4d5f932e55e6cb92895efca7

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests

Status Summary

Firefox

FAIL: 4

Chrome

FAIL: 4

Safari

PASS: 1
FAIL: 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-sizing/intrinsic-percent-replaced-007.html: FAIL (Chrome: FAIL, Safari: PASS)
/css/css-sizing/intrinsic-percent-replaced-008.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-sizing/intrinsic-percent-replaced-dynamic-007.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-sizing/intrinsic-percent-replaced-dynamic-008.html: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7b266647c78a
[wpt PR 22546] - [LayoutNG] Fixes OOF min/max sizes for nodes w/ %-dependent children., a=testonly
https://hg.mozilla.org/integration/autoland/rev/90814fe818c9
[wpt PR 22546] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/7b266647c78a
https://hg.mozilla.org/mozilla-central/rev/90814fe818c9

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox76: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
You need to log in before you can comment on or make changes to this bug.