1626182 - Support the SSO for chat.mozilla.org

Status: RESOLVED FIXED

(Chat Core :: Matrix, enhancement)

Comment 1

[Khushil Mistry [:khushil324]]

Attachment: WIP-Bug-1626182_Support-the-SSO.patch

Comment 2

[Martin Giger [:freaktechnik]]

Attachment: Bug 1626182 - Support Matrix SSO login flow. r=clokep

Comment 3

[Martin Giger [:freaktechnik]]

Comment on attachment 9185690 [details] [diff] [review]
WIP-Bug-1626182_Support-the-SSO.patch

The patch is based on the WIP from khushil. It adds proper login flow detection and fails login if there's a password but m.login.password is not supported, or if there is no password set and SSO isn't supported either. Further, this switches the matrix client over to using an access token by default (can be disabled in the account settings) and stores the device ID, which should lead to a side-effect of fixing of Bug 1679112. It also updates the behavior so the session is logged out of when the account is removed and if you re-login/authenticate the device ID should get re-used. All the session information is stored as prefs.

Lastly there are fixes to the OAuth window, since that browser was just blank. I didn't fix the window beyond "ok, it works now", so I'm not sure if everything is absolutely correct in an e10s world, and some of the UI doesn't look that great anymore...

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/07edcf4365a2
Support Matrix SSO login flow. r=clokep

Comment 6

[ildar.mulyukov]

Excuse me, is it still possible to have this in 78.x ?
88 is too far in the future.

Comment 7

[Magnus Melin [:mkmelin]]

No, so many other Matrix things are not working on 78. If you're in a hurry to use it you can use trunk. Even on trunk it's not enabled by default just yet.