1626210 - Connecting to remote device fails `Cc is not defined`

Status: RESOLVED FIXED

(DevTools :: about:debugging, defect, P1)

Description

[Julian Descottes [:jdescottes]]

STRs:

• open about:debugging
• try to connect to a remote device

ER: should connect successfully
AR: connection fails

Console logs: Cc is not defined

getFreeTCPPort@resource://devtools/client/shared/remote-debugging/adb/commands/prepare-tcp-connection.js:26:16
prepareTCPConnection@resource://devtools/client/shared/remote-debugging/adb/commands/prepare-tcp-connection.js:38:16
createUSBClient@resource://devtools/client/aboutdebugging/src/modules/runtime-client-factory.js:39:22
createClientForRuntime@resource://devtools/client/aboutdebugging/src/modules/runtime-client-factory.js:56:12
connectRuntime/<@resource://devtools/client/aboutdebugging/src/actions/runtimes.js:122:35
thunk/</<@resource://devtools/client/shared/redux/middleware/thunk.js:15:9
onClick@resource://devtools/client/aboutdebugging/src/components/sidebar/SidebarRuntimeItem.js:67:21
invokeGuardedCallbackImpl@resource://devtools/client/shared/vendor/react-dom.js:74:10
invokeGuardedCallback@resource://devtools/client/shared/vendor/react-dom.js:111:29
invokeGuardedCallbackAndCatchFirstError@resource://devtools/client/shared/vendor/react-dom.js:125:25
executeDispatch@resource://devtools/client/shared/vendor/react-dom.js:346:42
executeDispatchesInOrder@resource://devtools/client/shared/vendor/react-dom.js:365:20
executeDispatchesAndRelease@resource://devtools/client/shared/vendor/react-dom.js:462:29
executeDispatchesAndReleaseTopLevel@resource://devtools/client/shared/vendor/react-dom.js:470:10
forEachAccumulated@resource://devtools/client/shared/vendor/react-dom.js:444:8
runEventsInBatch@resource://devtools/client/shared/vendor/react-dom.js:598:21
runExtractedEventsInBatch@resource://devtools/client/shared/vendor/react-dom.js:606:19
handleTopLevel@resource://devtools/client/shared/vendor/react-dom.js:4272:30
batchedUpdates$1@resource://devtools/client/shared/vendor/react-dom.js:15752:12
batchedUpdates@resource://devtools/client/shared/vendor/react-dom.js:1882:12
dispatchEvent@resource://devtools/client/shared/vendor/react-dom.js:4351:19
interactiveUpdates$1/<@resource://devtools/client/shared/vendor/react-dom.js:15803:14
unstable_runWithPriority@resource://devtools/client/shared/vendor/react.js:617:12
interactiveUpdates$1@resource://devtools/client/shared/vendor/react-dom.js:15802:12
interactiveUpdates@resource://devtools/client/shared/vendor/react-dom.js:1901:10
dispatchInteractiveEvent@resource://devtools/client/shared/vendor/react-dom.js:4328:21

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1626210 - Import Cc,Ci in devtools prepare-tcp-connection.js

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0234d15d33c7
Import Cc,Ci in devtools prepare-tcp-connection.js r=daisuke

Comment 3

[Julian Descottes [:jdescottes]]

Adding leave-open as I would like to work on a test as well.

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 1626210 - Add a test for devtools prepare-tcp-connection

Depends on D68982

Comment 5

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/0234d15d33c7

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/63fc144ad6d3
Add a test for devtools prepare-tcp-connection r=daisuke

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/63fc144ad6d3