1626413 - Sorting by "Alerts" is broken when there are no vulnerable passwords

Status: VERIFIED FIXED

(Firefox :: about:logins, defect, P1)

Description

[Jared Wein [:jaws] (please needinfo? me)]

A bug in the code of login-list.js only used breach alerts and vulnerable password alerts in the sorting algorithm if both were present. When both aren't provided, it would fall back to sorting by 'name'.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1626413 - Allow sorting by 'alerts' even if vulnearble logins are not present. r?sfoster,MattN

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/500c7e81bdcc
Allow sorting by 'alerts' even if vulnerable logins are not present. r=MattN

Comment 3

[Bogdan Tara[:bogdan_tara | bogdant]]

Backed out changeset 500c7e81bdcc (bug 1626413) for browser_loginSortOrderRestored.js failures

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=windows%2C10%2Cx64%2Cdebug%2Cmochitests%2Ctest-windows10-64%2Fdebug-mochitest-browser-chrome-e10s-2%2Cm%28bc2%29&tochange=7afd0c50200b0993e063c065f3b89c78afb19017&fromchange=ecb0f5f13cd361a46f920ad5441ece7473add713&selectedJob=295845337

Backout link: https://hg.mozilla.org/integration/autoland/rev/7afd0c50200b0993e063c065f3b89c78afb19017

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=295845337&repo=autoland&lineNumber=13739

[task 2020-04-01T22:54:47.245Z] 22:54:47     INFO - TEST-START | browser/components/aboutlogins/tests/browser/browser_loginSortOrderRestored.js
[task 2020-04-01T22:54:47.406Z] 22:54:47     INFO - GECKO(2084) | [Child 10972: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 0000016BF2BD7800 == 6 [pid = 10972] [id = {48baf5e3-be1f-43b6-aa72-2086d32eaeac}]
[task 2020-04-01T22:54:47.406Z] 22:54:47     INFO - GECKO(2084) | [Child 10972: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 16 (0000016BEFF5BD40) [pid = 10972] [serial = 34] [outer = 0000000000000000]
[task 2020-04-01T22:54:47.406Z] 22:54:47     INFO - GECKO(2084) | [Child 10972: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 17 (0000016BF2B13000) [pid = 10972] [serial = 35] [outer = 0000016BEFF5BD40]
[task 2020-04-01T22:54:47.425Z] 22:54:47     INFO - GECKO(2084) | [Parent 4640, Main Thread] WARNING: '!mName', file /builds/worker/checkouts/gecko/editor/libeditor/EditAggregateTransaction.cpp, line 91
[task 2020-04-01T22:54:47.425Z] 22:54:47     INFO - GECKO(2084) | [Parent 4640, Main Thread] WARNING: EditAggregationTransaction::GetName() failed: 'NS_SUCCEEDED(rv)', file /builds/worker/checkouts/gecko/editor/libeditor/PlaceholderTransaction.cpp, line 217
[task 2020-04-01T22:54:47.425Z] 22:54:47     INFO - GECKO(2084) | [Parent 4640, Main Thread] WARNING: nsIAbsorbingTransaction::GetTxnName() failed, but ignored: 'NS_SUCCEEDED(rvIgnored)', file /builds/worker/checkouts/gecko/editor/libeditor/PlaceholderTransaction.cpp, line 188
[task 2020-04-01T22:54:47.504Z] 22:54:47     INFO - GECKO(2084) | [Child 10972: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 18 (0000016BF35F8C00) [pid = 10972] [serial = 36] [outer = 0000016BEFF5BD40]
[task 2020-04-01T22:54:47.624Z] 22:54:47     INFO - GECKO(2084) | [Child 10972, Main Thread] WARNING: '!mInitSucceeded', file /builds/worker/checkouts/gecko/editor/libeditor/TextEditSubActionHandler.cpp, line 102
[task 2020-04-01T22:54:47.869Z] 22:54:47     INFO - GECKO(2084) | [Child 10972: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 0000016BF020E800 == 7 [pid = 10972] [id = {e12d7679-3267-446c-80f0-ae7ec023d901}]
[task 2020-04-01T22:54:47.869Z] 22:54:47     INFO - GECKO(2084) | [Child 10972: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 19 (0000016BEFF5CF60) [pid = 10972] [serial = 37] [outer = 0000000000000000]
[task 2020-04-01T22:54:47.869Z] 22:54:47     INFO - GECKO(2084) | [Child 10972: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 20 (0000016BF3807C00) [pid = 10972] [serial = 38] [outer = 0000016BEFF5CF60]
[task 2020-04-01T22:54:47.879Z] 22:54:47     INFO - GECKO(2084) | [Child 10972, Main Thread] WARNING: SendNotifyIMEFocus got rejected.: file /builds/worker/checkouts/gecko/widget/PuppetWidget.cpp, line 793
[task 2020-04-01T22:54:47.881Z] 22:54:47     INFO - GECKO(2084) | [Parent 4640, Main Thread] WARNING: '!mName', file /builds/worker/checkouts/gecko/editor/libeditor/EditAggregateTransaction.cpp, line 91
[task 2020-04-01T22:54:47.882Z] 22:54:47     INFO - GECKO(2084) | [Parent 4640, Main Thread] WARNING: EditAggregationTransaction::GetName() failed: 'NS_SUCCEEDED(rv)', file /builds/worker/checkouts/gecko/editor/libeditor/PlaceholderTransaction.cpp, line 217
[task 2020-04-01T22:54:47.882Z] 22:54:47     INFO - GECKO(2084) | [Parent 4640, Main Thread] WARNING: nsIAbsorbingTransaction::GetTxnName() failed, but ignored: 'NS_SUCCEEDED(rvIgnored)', file /builds/worker/checkouts/gecko/editor/libeditor/PlaceholderTransaction.cpp, line 188
[task 2020-04-01T22:54:48.013Z] 22:54:48     INFO - GECKO(2084) | [Child 10972: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 21 (0000016BF3FC8000) [pid = 10972] [serial = 39] [outer = 0000016BEFF5CF60]
[task 2020-04-01T22:54:48.153Z] 22:54:48     INFO - GECKO(2084) | [Child 10972, Main Thread] WARNING: '!mInitSucceeded', file /builds/worker/checkouts/gecko/editor/libeditor/TextEditSubActionHandler.cpp, line 102
[task 2020-04-01T22:54:48.254Z] 22:54:48     INFO - TEST-INFO | started process screenshot
[task 2020-04-01T22:54:48.332Z] 22:54:48     INFO - TEST-INFO | screenshot: exit 0
[task 2020-04-01T22:54:48.332Z] 22:54:48     INFO - Buffered messages logged at 22:54:47
[task 2020-04-01T22:54:48.332Z] 22:54:48     INFO - Entering test bound setup
[task 2020-04-01T22:54:48.332Z] 22:54:48     INFO - Leaving test bound setup
[task 2020-04-01T22:54:48.332Z] 22:54:48     INFO - Entering test bound setup
[task 2020-04-01T22:54:48.332Z] 22:54:48     INFO - TEST_LOGIN1 added with guid={8d2c8c40-b267-4c74-821e-86d55cf4931c}
[task 2020-04-01T22:54:48.333Z] 22:54:48     INFO - TEST_LOGIN3 added with guid={87c63dd0-c3cb-4cb5-83fc-a31ad2087f12}
[task 2020-04-01T22:54:48.333Z] 22:54:48     INFO - Leaving test bound setup
[task 2020-04-01T22:54:48.333Z] 22:54:48     INFO - Entering test bound test_sort_order_persisted
[task 2020-04-01T22:54:48.333Z] 22:54:48     INFO - TEST-PASS | browser/components/aboutlogins/tests/browser/browser_loginSortOrderRestored.js | selected sort should be 'alerts' since there is a breached login - "alerts" == "alerts" - 
[task 2020-04-01T22:54:48.333Z] 22:54:48     INFO - TEST-PASS | browser/components/aboutlogins/tests/browser/browser_loginSortOrderRestored.js | the first login should be TEST_LOGIN3 since they are sorted by alerts - "{87c63dd0-c3cb-4cb5-83fc-a31ad2087f12}" == "{87c63dd0-c3cb-4cb5-83fc-a31ad2087f12}" - 
[task 2020-04-01T22:54:48.333Z] 22:54:48     INFO - TEST-PASS | browser/components/aboutlogins/tests/browser/browser_loginSortOrderRestored.js | the first login should be TEST_LOGIN1 since it has the most recent timePasswordChanged value - "{8d2c8c40-b267-4c74-821e-86d55cf4931c}" == "{8d2c8c40-b267-4c74-821e-86d55cf4931c}" - 
[task 2020-04-01T22:54:48.333Z] 22:54:48     INFO - TEST-PASS | browser/components/aboutlogins/tests/browser/browser_loginSortOrderRestored.js | 'last-changed' should be stored in the pref - 
[task 2020-04-01T22:54:48.333Z] 22:54:48     INFO - Buffered messages finished
[task 2020-04-01T22:54:48.334Z] 22:54:48     INFO - TEST-UNEXPECTED-FAIL | browser/components/aboutlogins/tests/browser/browser_loginSortOrderRestored.js | selected sort should be restored to 'alerts' since 'breached' was in prefs - "name" == "alerts" - 
[task 2020-04-01T22:54:48.334Z] 22:54:48     INFO - Stack trace:
[task 2020-04-01T22:54:48.334Z] 22:54:48     INFO - resource://testing-common/content-task.js line 110 > eval:null:9
[task 2020-04-01T22:54:48.334Z] 22:54:48     INFO - resource://testing-common/content-task.js:null:111
[task 2020-04-01T22:54:48.334Z] 22:54:48     INFO - TEST-PASS | browser/components/aboutlogins/tests/browser/browser_loginSortOrderRestored.js | the first login should be TEST_LOGIN3 since they are sorted by alerts - "{87c63dd0-c3cb-4cb5-83fc-a31ad2087f12}" == "{87c63dd0-c3cb-4cb5-83fc-a31ad2087f12}" - 
[task 2020-04-01T22:54:48.334Z] 22:54:48     INFO - GECKO(2084) | [Child 10972, Main Thread] WARNING: SendNotifyIMEFocus got rejected.: file /builds/worker/checkouts/gecko/widget/PuppetWidget.cpp, line 793
[task 2020-04-01T22:54:48.334Z] 22:54:48     INFO - TEST-PASS | browser/components/aboutlogins/tests/browser/browser_loginSortOrderRestored.js | confirm that the stored sort is still 'breached' and as such shouldn't apply when the page loads - 
...

At the moment seeing this only on Windows 10 x64 debug.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4f97d7e79d15
Allow sorting by 'alerts' even if vulnearble logins are not present. r=MattN

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/4f97d7e79d15

Comment 6

[Simona Rosu [:srosu], Ecosystem QA]

I have verified this issue using the latest Nightly 76.0a1 (Build ID: 20200402095145) on Windows 10 x64, Mac 10.14, Ubuntu 18.04 x64.

• The saved logins are correctly sorted if there are no vulnerable logins.