1627627 - The “Alerts” option is not displayed in “Sort by:” dropdown after syncing logins without refreshing the page if previously no breached/vulnerable were saved

Status: VERIFIED FIXED

(Firefox :: about:logins, defect, P2)

Description

[Simona Rosu [:srosu], Ecosystem QA]

Attachment: AlertsOptionIsNotDisplayedAfterSync.gif

[Affected versions]:

• Nightly 76.0a1 (Build ID: 20200405212522)

[Affected Platforms]:

• Windows 10 x64
• Mac 10.14.6
• Ubuntu 18.04 x64

[Prerequisites]:

• No vulnerable/breached accounts are displayed in the login list.
• Have a Firefox Account with saved logins in which at least one is vulnerable and one is breached.

[Steps to reproduce]:

1. Open the Firefox browser with the profile from prerequisites.
2. Navigate to the “about:logins” page.
3. Sign in to Sync with the Firefox Account from prerequisites.
4. Click on the “Sort by:” button.
5. Observe the dropdown menu.

[Expected result]:

• The “Alerts” option is displayed on the dropdown.

[Actual result]:

• The “Alerts” option is not displayed on the dropdown.

[Regression]

• The issue is not reproducible with older Nightly 76.0a1 builds. Considering this, using the mozregression tool I have found the issue that broke this in the latest Nightly build. Here are the results:
• Pushlog: https://tinyurl.com/ss3vbj6.
• Last good revision: 6e570f08779fae0699aec929011f3e0f8d668c33.
• First bad revision: 4f97d7e79d15a71b12d268e1eb3967a79c3adaa9.

From this pushlog it seems that Bug 1626413 introduced this behavior.

[Notes]:

• The “Alerts” option is displayed after refreshing the page.
• This issue is not reproducible if I have breached/vulnerable logins saved in the profile before signing in to Sync.
• Attached a screen recording with the issue.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1627627 - Show the 'Alerts' dropdown option if a login is vulnerable or breached login is added while the page is already open. r?MattN

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/31d79b7eeabe
Show the 'Alerts' dropdown option if a login is vulnerable or breached login is added while the page is already open. r=MattN

Comment 3

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/31d79b7eeabe

Comment 4

[Simona Rosu [:srosu], Ecosystem QA]

I have verified this issue using the latest Nightly 77.0a1 (Build ID: 20200412214115) on Windows 10 x64, Mac 10.14, Ubuntu 18.04 x64.

• The “Alerts” option is displayed in “Sort by:” dropdown after syncing logins if previously no breached/vulnerable were saved.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:jaws, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 9139581 [details]
Bug 1627627 - Show the 'Alerts' dropdown option if a login is vulnerable or breached login is added while the page is already open. r?MattN

Beta/Release Uplift Approval Request

• User impact if declined: Users may not see the "Alerts" dropdown option after a login is added to Firefox while about:logins is opened
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Covered by automated tests and is limited to about:logins
• String changes made/needed: none

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9139581 [details]
Bug 1627627 - Show the 'Alerts' dropdown option if a login is vulnerable or breached login is added while the page is already open. r?MattN

Approved for 76.0b5.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/65b23e473a4d

Comment 9

[Simona Rosu [:srosu], Ecosystem QA]

I have verified this issue using the Firefox Beta 76.0b5 (Build ID: 20200415234430) on Windows 10 x64, Mac 10.14, Ubuntu 18.04 x64.

• The “Alerts” option is displayed in “Sort by:” dropdown after syncing logins if previously no breached/vulnerable were saved.