1626472 - Allow revealing of passwords in the capture doorhanger with OS reauthentication

Status: NEW

(Toolkit :: Password Manager, enhancement, P3)

Description

[Sam Foster [:sfoster] (he/him)]

The password visibility checkbox in the save and change password doorhangers currently has a set of conditions and heuristics to try and prevent password snooping.

The OS reauth mechanism is now used for this purpose in about:logins (bug 1194529) and could be used here for a better and more consistent user experience.

Comment 1

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1626472 - Refactor the OSKeyStore reauthentication into a LoginHelper method, add canReauth method on OSKeyStore. r?Jaws

• New canReauth method on OSKeyStore
• Move MP and OSKeyStore.ensureLoggedIn checks from AboutLoginParent to new requestReauth method on LoginHelper
• Remove OSKeyStoreTestUtils.canTestOSKeyStoreLogin in favor of OSKeyStore.canReauth
• Set a default value for the TEST_ONLY_REAUTH pref in aboutlogins b-c tests using OSKeyStore.canReauth to match actual platform support

Comment 2

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1626472 - (WIP) Use OS reauth when possible to toggle password visibility in the doorhanger.

Comment 3

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1626472 - Provide a helper for getting a nsIMIMEInfo on DownloadsCommon. r?Gijs

Depends on D73773

Comment 4

[Phabricator Automation]

Comment on attachment 9146661 [details]
Bug 1626472 - Provide a helper for getting a nsIMIMEInfo on DownloadsCommon. r?Gijs

Revision D74354 was moved to bug 1191591. Setting attachment 9146661 [details] to obsolete.

Comment 5

[Sam Foster [:sfoster] (he/him)]

(In reply to Phabricator Automation from comment #4)

Revision D74354 was moved to bug 1191591. Setting attachment 9146661 [details] to obsolete.

Thanks for fixing my copy pasta.

Comment 6

[Phabricator Automation]

Comment on attachment 9137620 [details]
Bug 1626472 - Refactor the OSKeyStore reauthentication into a LoginHelper method, add canReauth method on OSKeyStore. r?Jaws

Revision D67681 was moved to bug 1639347. Setting attachment 9137620 [details] to obsolete.

Comment 7

[Sam Foster [:sfoster] (he/him)]

I'm unassigning myself. The patch on phabricator represents pretty much where I got to with this, but I'm happy to sit down and discuss. With the LoginHelper.requestReauth patch landed, the remaining work should be fairly straight-forward to hook the request into the prompt code.

Comment 8

[Sam Foster [:sfoster] (he/him)]

https://phabricator.services.mozilla.com/D68967 will need rebasing before continuing. That was work-in-progress and isn't expected to work as-is, but I'm happy to walk through what the goal is here and how to get there.