1630556 - "Show password" toggle is displayed for autofilled password edits on the multi-page form on booking.com

Status: NEW

(Toolkit :: Password Manager: Site Compatibility, defect, P3)

Description

[Alin Ilea, Desktop QA]

Attachment: booking.com show password issue..mp4

Tested with:

Beta 76.0b5 (64-bit)
Nightly 77.0a1 (2020-04-16)

Tested on:

Windows 10 - affected
Windows 7 - affected
Mac OS 10.13 - affected
Ubuntu 18.04 - affected

Steps:

1. Launch Firefox with a new profile, go to booking.com and reach the sign in form.
2. Fill in the username and click next.
3. Fill in the password and focus out of the field.
4. Click on the grey key icon to toggle the dismissed doorhanger and click on Save.
5. Go back to the username field using the browser back button and click Next.
6. In the password field edit the existing password and focus out of the field.
7. Click on the grey key icon to toggle the dismissed doorhanger.

Actual result:

"Show password" toggle is displayed in the dismissed doorhanger.

Expected result:

"Show password" toggle should not be displayed in the dismissed doorhanger after editing the password.

Note: On other sites like google.com, live.com, microsoft.com, amazon.com the issue is not reproducible, "Show password" toggle is not displayed.

Comment 1

[Sam Foster [:sfoster] (he/him)]

I can confirm this. When we show the doorhanger, if the form was autofilled with a saved login we should hide that "Show password" toggle. It looks like when we look up the autofilled login before sending the message to show the doorhanger, we fail to find it. The entry in docState.fillsByRootElement is there for the username and password fields, but the form element doesn't match it. As this is a WeakMap, it means the site is destroying and recreating the form after we've autofilled the fields.

In some cases it might be reasonable to recreate the entry based on a selector to re-identify the fields we autofilled, but that's not a general solution. I'm open to ideas.

Possibly related, you can see in the video on comment #0 the filled fields do not have the yellow highlight you would normally expect from form autofill.

Bug 1626472 would greatly improve this situation. I'll add as see-also for now.