1626474 - Set IsFunction, IsForEval, and IsModule earlier

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P2)

Description

[Caroline Cullen [:caroline]]

These three flags are all set very early on in compilation, by the specific compilation method used and not the test itself being parser, although it is not obvious that they should be included with input flags. Setting them earlier will make it obvious that these flags belong as part of the input flags and help to clarify what conditions are present and whether a stencil can be reused.

Comment 1

[Ted Campbell [:tcampbell]]

Probably can also remove SharedContext::kind_ and rely on these ImmutableFlags instead.

Comment 2

[Caroline Cullen [:caroline]]

Attachment: Bug 1626474 - Reorder to make IsFunction, IsForEval, and IsModule input flags. r?tcampbell

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4393410345bf
Reorder to make IsFunction, IsForEval, and IsModule input flags. r=tcampbell

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/4393410345bf