1626507 - Remove the document channel exception for about:newtab

Status: RESOLVED FIXED

(Core :: DOM: Navigation, task, P3)

Description

[Paul Bone [:pbone]]

In Bug 1597154 I added an exception for about:newtab, this should be removed, but doing so breaks browser/components/uitour/test/browser_UITour_showNewTab.js where the address bar isn't focused for the new tab. This should be fixed and the exception can be removed.

Comment 1

[Chris Peterson [:cpeterson]]

Tracking for Fission M6a because Paul said he wanted to clean up this code soon.

Comment 2

[Paul Bone [:pbone]]

Attachment: Bug 1626507 - pt 1. Remove documentchannel exceptions r=mattwoodrow

This patch removes the excemptions for about:newtab, about:home and
about:blank.

When we switch processes using session restore we sometimes focus the
content area. We mustn't do this if the uri is undefined, this can happen
for some of these pages and we expect the address bar to be focused instead.

Comment 3

[Paul Bone [:pbone]]

Attachment: Bug 1626507 - pt 2. Update comment since code has moved r=mattwoodrow

Depends on D80339

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d2e886102c03
Remove documentchannel exceptions r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/92117ff66bda
Update comment since code has moved r=mattwoodrow

Comment 5

[Dorel Luca [:dluca]]

Backed out 2 changesets (bug 1626507) on dev's request

TH push:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=92117ff66bda4ddad1595779260871cd6d8f73c9

Backout:
https://hg.mozilla.org/integration/autoland/rev/3fb178e66766fa831ee5e2408efd7cdb088e5484

Comment 6

[Paul Bone [:pbone]]

Attachment: Bug 1626507 - pt 3. Rename a test to make it distinct from other tests r=mattwoodrow

Two tests in this file had the same name, give this one a more specific name
so that console output is easier to follow.

Depends on D80594

Comment 7

[Paul Bone [:pbone]]

Attachment: Bug 1626507 - pt 4. Fix openPreferencesViaOpenPreferencesAPI r=mattwoodrow

Due to changes in about:newtab somehow the preferences code is getting
initialised before the call to openPreferencesViaOpenPreferencesAPI().
Update this code to work when preferences is already initialised.

Depends on D81066

Comment 8

[Paul Bone [:pbone]]

I said in the meeting today that this is blocked on fixing BC preservation, it isn't. The reason it can't land is that there's still test failures to fix:

https://treeherder.mozilla.org/#/jobs?repo=try&selectedTaskRun=KoHNcnIpTkOTn-14mA-aEA.0&revision=f7a47df5aab71f54befed4bf4ddceaad89f68f88

Comment 9

[Neha Kochar [:neha]]

Paul, please provide an ETA for this in the whiteboard field.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/641595f11928
pt 1. Remove documentchannel exceptions r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/2a0d4fe417c0
pt 2. Update comment since code has moved r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/521431bda0c7
pt 3. Rename a test to make it distinct from other tests r=preferences-reviewers,jaws
https://hg.mozilla.org/integration/autoland/rev/b351d22f9100
pt 4. Fix openPreferencesViaOpenPreferencesAPI r=preferences-reviewers,jaws

Comment 11

[Paul Bone [:pbone]]

Attachment: Bug 1626507 - pt 5. Remove duplicate call to openPreferences r=gijs

I didn't see this reviewer comment on my patch until after I'd clicked land.
Sorry.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/89354b22efcd
pt 5. Remove duplicate call to openPreferences r=Gijs,preferences-reviewers

Comment 13

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/641595f11928
https://hg.mozilla.org/mozilla-central/rev/2a0d4fe417c0
https://hg.mozilla.org/mozilla-central/rev/521431bda0c7
https://hg.mozilla.org/mozilla-central/rev/b351d22f9100

Comment 14

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/89354b22efcd